Fix refresh ticker dropping operations #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that the remote refreshing of persisted operations would sometimes drop operations from specific files. There seems to be a scenario where a file is correctly downloaded from the remote, and stored locally, but when reading the file right after it would see an empty file still.
This cleans up the code around that mechanism, provides additional protections for concurrent processing and fixes the issue. The applied fix may not be the prettiest, but it does the trick and can be supplied faster than diving into why there is a discrepancy when writing to a file and reading it straight after.