Feature/allow loading files from subdirs #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 13, 2024 12:19
- number of files process - time it took to download said files add metric on how long it took add support for downloading files in subdir's
ldebruijn
requested changes
Mar 13, 2024
added 3 commits
March 13, 2024 14:05
add docs on what the getFile function does
ldebruijn
requested changes
Mar 13, 2024
added 3 commits
March 13, 2024 15:19
add metric for hashes in memory
ldebruijn
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add logging on:
add metric on how long it took
add support for downloading files from GCS subdir's