fix: raise an error on ]]> in character data

lddubeau · Jul 6, 2018 · 2964381 · 2964381
1 parent c007e39
commit 2964381
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/lib/saxes.js b/lib/saxes.js
@@ -282,7 +282,11 @@ class SAXParser {
               }
             }
           }
-          this.textNode += chunk.substring(starti, i - 1);
+          const fragment = chunk.substring(starti, i - 1);
+          if (fragment.includes("]]>")) {
+            this.fail("The string \"]]>\" is disallowed in char data.");
+          }
+          this.textNode += fragment;
         }
         if (c === "<") {
           this.state = S_OPEN_WAKA;
@@ -673,6 +677,9 @@ class SAXParser {
           }
           continue;
         }
+        if (this.attribValue.includes("]]>")) {
+          this.fail("The string \"]]>\" is disallowed in char data.");
+        }
         this.attribList.push([this.attribName, this.attribValue]);
         this.attribName = this.attribValue = "";
         this.q = "";
@@ -710,6 +717,9 @@ class SAXParser {
           }
           continue;
         }
+        if (this.attribValue.includes("]]>")) {
+          this.fail("The string \"]]>\" is disallowed in char data.");
+        }
         this.attribList.push([this.attribName, this.attribValue]);
         this.attribName = this.attribValue = "";
         if (c === ">") {