Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compare of reals. #782

Merged
merged 1 commit into from
Nov 12, 2014
Merged

Fix compare of reals. #782

merged 1 commit into from
Nov 12, 2014

Conversation

redstar
Copy link
Member

@redstar redstar commented Nov 10, 2014

Comparing 2 reals for equality is done with memcmp(). The length was hardcoded to 10
which is wrong on all platforms with 64bit reals.

Comparing 2 reals for equality is done with memcmp(). The length was hardcoded to 10
which is wrong on all platforms with 64bit reals.
@dnadlinger
Copy link
Member

Port depending on Target strikes me as a dependency that is entirely the wrong way around. Port is supposed to be concerned with host functions, not target ones.

@redstar
Copy link
Member Author

redstar commented Nov 10, 2014

It is simply a sign that dmd has no real distinction between host and target. The floating point machinery is totally target dependent but the details are spread over the source: the longdouble class, the Target class and the Port functions all contribute to this machinery.

redstar added a commit that referenced this pull request Nov 12, 2014
@redstar redstar merged commit 23668b1 into ldc-developers:master Nov 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants