Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and re-enable core.internal.convert unit tests #788

Closed
dnadlinger opened this issue Nov 13, 2014 · 4 comments
Closed

Fix and re-enable core.internal.convert unit tests #788

dnadlinger opened this issue Nov 13, 2014 · 4 comments

Comments

@dnadlinger
Copy link
Member

See #770.
@dnadlinger dnadlinger changed the title Fix core.internal.convert unit tests Fix and re-enable core.internal.convert unit tests Nov 13, 2014
@smolt
Copy link
Member

smolt commented Jun 2, 2015

I suppose the internal/convert.d unittest fix should go upstream first. Tested on X86 and ARM.

        // don't test pad bytes because can be anything    
        enum testsize =
            (FloatTraits!TYPE.EXPONENT + FloatTraits!TYPE.MANTISSA + 1)/8;
        assert(rtbytes[0..testsize] == ctbytes[0..testsize]);

@smolt smolt mentioned this issue Jun 3, 2015
Merged
@smolt
Copy link
Member

smolt commented Jun 3, 2015

dlang/druntime#1297

@smolt
Copy link
Member

smolt commented Jun 5, 2015

If questioning if fixing test is right thing, note that clang doesn't zero pad x87 long doubles either. The last 6-bytes are whatever happens to already be in memory. Makes sense because eliminates extra instructions needed to zero bytes that don't have any affect on long double computations.

@smolt smolt mentioned this issue Dec 13, 2015
Merged
smolt added a commit to smolt/ldc that referenced this issue Dec 23, 2015
@smolt
Re-enable core.internal.convert unit tests
14c0643 
Update druntime submodule with core.internal.convert changes and start
running its unit test again.

This should resolve issue ldc-developers#788.
@smolt smolt mentioned this issue Dec 23, 2015
Merged
@dnadlinger
Copy link
Member Author

#1241 merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dnadlinger @smolt