Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for medpro (and medcoupling) on windows #1

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

Krande
Copy link
Contributor

@Krande Krande commented Mar 14, 2024

Hey @ldallolio! In connection with conda-forge/staged-recipes#24378 (comment) I used medpro to validate the compiled version of medcoupling on windows. All tests are passing :) (meaning we're close to merging medcoupling and releasing it on conda-forge).

I only had to make a few changes to get it working on windows.

  • I made a pytest fixture for the example dir and used pathlib to ensure it would resolve the relative path more easily.
  • And I had to add a conditional so that it uses a different write method on windows.

Let me know if you have any comments?

Best Regards
Kristoffer

@Krande Krande changed the title Add support for medcoupling on windows Add support for medpro (and medcoupling) on windows Mar 14, 2024
@ldallolio ldallolio merged commit 06f3a97 into ldallolio:main Mar 14, 2024
@ldallolio
Copy link
Owner

Hi Kristoffer,

You did I great job ! I will make this into a conda-forge package as soon as we get medcoupling accepted :)
You used the "write" method instead of the "write33" in windows, I supposed it worked better in your case, it will write in the new med 4 format instead of the "old" 3.3.1 format (not a big deal for a lot of people), did you have some issues with write33 ?

Thank you for your contribution!
All the best,
Luca

@Krande
Copy link
Contributor Author

Krande commented Mar 14, 2024

Yeah, write33 resulted in InterpKernelException:

medcoupling.InterpKernelException: Return code of MEDFile call "MEDfileCommentWr" is not 0 as expected during writing operation ! ( Return code was -1 at C:\work\miniforge3\envs\mamba-build\conda-bld\medcoupling_1710416826555\work\src\MEDLoader\MEDFileData.cxx:369 ). Check write access on MED file ?

Aha, so that's the difference between the different write methods. Good to know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants