Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for LaTeX Error cslreferences undefined #4

Merged
merged 2 commits into from
Dec 21, 2020

Conversation

LDSamson
Copy link
Contributor

@LDSamson LDSamson commented Dec 1, 2020

Hi Leon, Thanks for making this template! I am trying to adjust it for a Groningen university thesis. I came across this error regarding csl references after upgrading to the latest Rstudio (v1.4). This change in the template fixed it for me. Please check it yourself before accepting, my Latex knowledge is limited.

The error occurs in pandoc v2.8 and higher, due to a change in pandoc and its standard .tex template. See also ismayc/thesisdown#79 (comment)

LDSamson and others added 2 commits December 1, 2020 16:07
Error occurs in pandoc v2.8 and higher, due to a change in pandoc and its standard .tex template. See also ismayc/thesisdown#79 (comment)
@lcreteig
Copy link
Owner

Hi LDSamson,

Many thanks for reporting this and proposing a fix! Sorry for not coming back to you sooner.

I tried your change out with pandoc 2.8, but it still threw an error. Perhaps your version of RStudio comes bundled with an even newer version of pandoc? You can find this out with rmarkdown::pandoc_version().

I slightly modified your version according to the fix in rstudio/rticles#335. It should work with all pandoc versions now, but it would be great if you could try it out and confirm that everything still works fine on your end. Then I can merge the PR.

@LDSamson
Copy link
Contributor Author

No problem, thank you for making this template in the first place. I indeed have a newer Pandoc version (2.11.2). My proposed fix was probably not backwards compatible. I expect that your modifications will work; I will try it out this week and let you know

@LDSamson
Copy link
Contributor Author

Yes, I tested it and it works fine now with Pandoc 2.11.2!

@lcreteig lcreteig merged commit f53351e into lcreteig:master Dec 21, 2020
@lcreteig
Copy link
Owner

Great; thanks again!

lcreteig added a commit that referenced this pull request May 14, 2022
Following bibliography rework in #9.

Closes #4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants