Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gui): incorrect horizontal scroll bar style (#219) #220

Merged
merged 1 commit into from
May 15, 2021

Conversation

lc-soft
Copy link
Owner

@lc-soft lc-soft commented Aug 17, 2020

Fixes #219

Changes proposed in this pull request:

  • Rename css class name.
  • Use the LCUI_ScrollBar prefix instead of the SBD_ prefix to make the enumeration easier to understand.
  • Add test.

@commit-lint
Copy link

commit-lint bot commented Aug 17, 2020

Bug Fixes

Contributors

lc-soft

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #220 (0801908) into develop (34c3dca) will not change coverage.
The diff coverage is 45.45%.

❗ Current head 0801908 differs from pull request most recent head f41f14f. Consider uploading reports for the commit f41f14f to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #220   +/-   ##
========================================
  Coverage    55.06%   55.06%           
========================================
  Files           91       91           
  Lines        16679    16679           
========================================
  Hits          9184     9184           
  Misses        7495     7495           
Impacted Files Coverage Δ
src/gui/widget/scrollbar.c 34.07% <45.45%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80708aa...f41f14f. Read the comment docs.

@lc-soft lc-soft changed the title fix(gui): incorrect horizontal scroll bar style (#219) fix(gui): incorrect horizontal scroll bar style (#219) [WIP] Sep 30, 2020
@lc-soft lc-soft force-pushed the fix-scrollbar-direction branch from 0801908 to 39e1646 Compare May 5, 2021 14:22
@lc-soft lc-soft changed the title fix(gui): incorrect horizontal scroll bar style (#219) [WIP] fix(gui): incorrect horizontal scroll bar style (#219) May 5, 2021
@lc-soft lc-soft force-pushed the fix-scrollbar-direction branch from 39e1646 to 67c29dd Compare May 15, 2021 13:42
@lc-soft lc-soft force-pushed the fix-scrollbar-direction branch from 67c29dd to f41f14f Compare May 15, 2021 14:46
@lc-soft lc-soft merged commit 31dee24 into develop May 15, 2021
@lc-soft lc-soft deleted the fix-scrollbar-direction branch May 15, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error setting horizontal scroll bar. ScrollBar_SetDirection;
1 participant