fix: conditional jump or move depends on uninitialised value(s)

lc-soft · May 30, 2021 · 7174868 · 7174868
1 parent 9f4e72e
commit 7174868
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/src/gui/widget_event.c b/src/gui/widget_event.c
@@ -876,7 +876,7 @@ LCUI_Widget LCUIWidget_GetFocus(void)
 int LCUIWidget_SetFocus(LCUI_Widget widget)
 {
 	LCUI_Widget w;
-	LCUI_WidgetEventRec ev;
+	LCUI_WidgetEventRec ev = { 0 };
 
 	for (w = widget; w; w = w->parent) {
 		if (Widget_Focusable(w)) {

diff --git a/src/platform/linux/linux_x11display.c b/src/platform/linux/linux_x11display.c
@@ -238,7 +238,9 @@ static void X11Surface_ClearTasks(LCUI_Surface surface)
 static void OnDestroySurface(void *data)
 {
 	LCUI_Surface s = data;
+
 	X11Surface_ClearTasks(s);
+	LinkedList_Clear(&s->rects, free);
 	if (s->ximage) {
 		XDestroyImage(s->ximage);
 	}

diff --git a/test/test_scrollbar.c b/test/test_scrollbar.c
@@ -100,7 +100,7 @@ int BuildContentViewFromXML(void)
 void test_scrollbar(void)
 {
 	float left, top;
-	LCUI_SysEventRec e;
+	LCUI_SysEventRec e = { 0 };
 	LCUI_Widget content;
 
 	LCUI_Init();