Replace decprected route mixins (ember-simple-auth) #36
Conversation
Even though index should work as the other routes, the this.currectSession.load function does not get called automatically when redirected by mock-login. The requireAuth gets called because when logging out , it will otherwise not redirect you away from the page but stay with every module showing it is disabled
This gives the most issues. When logging out, the sessionInvalidated function should be called but it does not since it thinks the function resides in the session service. So what I think needs to happen is that functions need to be moved to be inside the session service
aatauil
changed the title
|
👀 following because we will want to do the same in GN |
|
The PR has a pretty good explanation on what to do to upgrade The only thing that wasn't very clear was replacing the |
|
Optional, and it's probably a nice premature DRY refactor 😄 : Since the session service is already extended, you could override the |
|
@Windvis Yeah actually that would be nice, but at the same time it should always be flexible to accept other routes in case this is needed in the future ( who knows ). So probable an |
Handling this logic in the session service is a direct replacement of the previous implementation. This also has the benefit that no extra `currentSession.load()` calls are needed if the default page is ever changed in the future.
…e-changes Move the "current session" loading logic into the session service
|
The issue with switch-login, is known on chrome, where a pop-up is blocked when coming from a redirect. And will not be tackled here. (Unless someone has an idea) The plan would be to see how we can replace the popup by an iframe. |
No description provided.