Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN-5480: load editor styles before app styles #829

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Feb 28, 2025

Overview

This PR ensures that the editor styles are loaded before the app styles. This ensures that the app styles take priority over the styles of the appuniversum and editor packages.

connected issues and PRs:

GN-5480

How to test/reproduce

  • Start the app
  • Open a meeting page
  • Ensure the styling of the meeting page is as expected
  • Ensure the styles of an editor page have not changed

Challenges/uncertainties

Unsure why we were loading the editor styles after the app styles, but this approach seems safer to me.

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma added the bug Something isn't working label Feb 28, 2025
@elpoelma elpoelma merged commit 09a10cb into master Feb 28, 2025
3 checks passed
@elpoelma elpoelma deleted the GN-5480-fix-css branch February 28, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant