Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update models and relationships #462

Merged
merged 13 commits into from
May 31, 2023
Merged

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented May 15, 2023

This PR includes a complete revisal/update of all ember-data models. It includes the removal of models and relationships, the addition of missing models and relationships and ensuring the inverse field is always explicitly set (in prepreration for emberjs/data#8115).
Specifically, it includes the removal of the following ember-data models:

  • task-solution
  • task
  • tasklist-solution
  • tasklist
  • versioned-agenda

And the removal of the following relationships:

  • realisatie from besluit
  • versioned-agendas, versioned-notulen, versioned-besluiten-lijsten and versioned-behandelingen from document-container
  • replaced versioned-agenda model type by agenda in published-resource
  • replaced versioned-agenda model type by agenda in signed-resource

The addition of the following models:

  • beleidsdomein-code
  • lidmaatschap
  • lijsttype
  • tijdsinterval
  • werkingsgebied

Additionally, this PR also introduces spacing in some models to make them clearer and more readable.
To be tested in combination with lblod/app-gelinkt-notuleren#156

@elpoelma elpoelma requested review from nvdk and lagartoverde May 15, 2023 10:11
@elpoelma elpoelma marked this pull request as draft May 15, 2023 10:23
Copy link
Member

@nvdk nvdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@elpoelma elpoelma changed the title Remove obsolete models and relationships Update models and relationships May 18, 2023
@elpoelma elpoelma requested a review from abeforgit May 18, 2023 09:56
@elpoelma elpoelma marked this pull request as ready for review May 18, 2023 09:59
Copy link
Contributor

@lagartoverde lagartoverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@elpoelma elpoelma requested a review from nvdk May 22, 2023 08:17
Copy link
Member

@abeforgit abeforgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting the same error as here:
#431 (review)

@elpoelma
Copy link
Contributor Author

getting the same error as here: #431 (review)

Aha ok, should be fixed now. The issue was that when I reset the inverses to null for some models which had their inverse as null before, I forgot to check if the other side of the relationship also had inverse: null. That should be fixed now, I rechecked all inverses and don't see anymore issues with the meeting page.

@abeforgit abeforgit enabled auto-merge May 31, 2023 07:01
@abeforgit abeforgit merged commit 86eaf63 into master May 31, 2023
@abeforgit abeforgit deleted the internal/clean-up-ember-data-models branch May 31, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants