Feature/detail enhance municipality button behavior #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Denperidge
approved these changes
Jul 11, 2023
Denperidge
reviewed
Jul 12, 2023
| })); | ||
|
|
||
| return session; | ||
| return this.store.findRecord('session', session_id, { |
There was a problem hiding this comment.
I think we might have had the same idea for simplifying this request, I think I also did something similar in one of the PR's woopss
But that's neither here nor there, we'll cross that bridge when we get there! Love the streamlining you did
Denperidge
approved these changes
Jul 12, 2023
Windvis
requested changes
Jul 12, 2023
- Improve accessing async relationships in `AgendaItemModel` and `DetailRoute` - Improve typing in `AgendaItemModel` and `DetailRoute` - start vote code cleaning
|
@Windvis ready for the next round! 🏓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
agenda-item,sessionandgoverning-body(Related to the BREAKING CHANGE API Fix(resources): agenda-item can have many sessions app-burgernabije-besluitendatabank#17)administrative-unit.location.labeleverywhere to resolve municipality name instead ofadministrative-unit.name:has:from query