Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Th-232 series notebook example #420

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Conversation

markbandstra
Copy link
Member

The NNDC data querying example notebook needed two updates:

  • It was using a deprecated pandas method (DataFrame.append), replaced with pandas.concat
  • The radiation from the thorium series started at Th-228 for reasons obscure to me (maybe because we had a Th-228 source in the lab), so if you refer to it for the natural thorium background lines it is missing some important ones.

@markbandstra markbandstra self-assigned this Oct 15, 2024
@markbandstra
Copy link
Member Author

markbandstra commented Oct 15, 2024

@jvavrek seems like the only problem is a liccheck issue and I'm not sure why it's even checking the pillow version since it's not a dependency.

Run Python License Checker...............................................Failed
- hook id: liccheck
- exit code: 255

gathering licenses...
45 packages and dependencies.
check authorized packages...
44 packages.
check unknown packages...
1 package.
    pillow (11.0.0): ['CMU License (MIT-CMU)']
      dependency:
          pillow << matplotlib

@jvavrek
Copy link
Contributor

jvavrek commented Oct 15, 2024

CMU is fine, so you could add exactly CMU License (MIT-CMU) to the .liccheck.ini

We could also disable checking the downstream dependencies in the tool.

@markbandstra markbandstra merged commit 9d6d6bc into main Oct 15, 2024
21 checks passed
@markbandstra markbandstra deleted the update-th232-example branch October 15, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants