Move warnings-as-errors config to pytest.ini and handle IDAES/idaes-p…

…se#1549

.github/workflows/checks.yml

@@ -27,7 +27,7 @@ defaults:
 env:
   # --color=yes needed for colorized output to be shown in GHA logs
   # --pyargs watertap is needed to be able to define CLI options in watertap/conftest.py
-  PYTEST_ADDOPTS: "--color=yes -Werror"
+  PYTEST_ADDOPTS: "--color=yes"
   PIP_PROGRESS_BAR: "off"
   WATERTAP_KERNEL_NAME: watertap-dev
 

pytest.ini

@@ -6,4 +6,8 @@ testpaths = watertap
 log_file = pytest.log
 log_file_date_format = %Y-%m-%dT%H:%M:%S
 log_file_format = %(asctime)s %(levelname)-7s <%(filename)s:%(lineno)d> %(message)s
-log_file_level = INFO
+log_file_level = INFO
+filterwarnings =
+    error
+    # see IDAES/idaes-pse#1549
+   ignore:unclosed file .*Visualization-data/SA-.*\.bin:ResourceWarning