Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the KOFR index #2087

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Add the KOFR index #2087

merged 1 commit into from
Oct 14, 2024

Conversation

jongbongan
Copy link
Contributor

Korea Overnight Financing Repo Rate (KOFR) published by Korea Securities Depository (KSD)

Please refer to
(1) https://www.bok.or.kr/eng/main/contents.do?menuNo=400399 (Overview)
(2) https://www.kofr.kr/main.jsp (Detailed information)

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2024

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Oct 8, 2024

Coverage Status

coverage: 72.671% (-0.003%) from 72.674%
when pulling 61793d8 on jongbongan:south_korea_ois
into 4cf0296 on lballabio:master.

@lballabio
Copy link
Owner

Thanks! May you check the CLAassistant comment? It might be because you committed with a different author email which is not associated to your GitHub account.

@lballabio lballabio added this to the Release 1.37 milestone Oct 8, 2024
@jongbongan
Copy link
Contributor Author

Thanks! May you check the CLAassistant comment? It might be because you committed with a different author email which is not associated to your GitHub account.

I will. Thank you.

@jongbongan
Copy link
Contributor Author

I think I would rather make another PR whose differences are same with this. (3357428 is actually my corporate PC, which is not a GitHub user.)

@sweemer
Copy link
Contributor

sweemer commented Oct 9, 2024

You can just amend the author on the commit and force push the branch.

@jongbongan
Copy link
Contributor Author

You can just amend the author on the commit and force push the branch.

I will try it.

@jongbongan
Copy link
Contributor Author

I rebased it to remove the author 3357428. Thanks @sweemer @lballabio

@lballabio lballabio changed the title add a kofr index Add the KOFR index Oct 14, 2024
@lballabio lballabio merged commit d855dce into lballabio:master Oct 14, 2024
43 checks passed
@jongbongan jongbongan deleted the south_korea_ois branch October 21, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants