Disambiguate cache key for similarly named models #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two models with the same name in different apps would previously get the same cache key. Including the model's module in the cache key fixes this.
|
@ahumeau Could you provide a unit test? |
|
@johnthagen sure :). |
johnthagen
reviewed
Oct 7, 2024
| @@ -64,7 +64,7 @@ def set_to_cache(self) -> None: | |||
| @classmethod | |||
| def get_cache_key(cls) -> str: | |||
| prefix = getattr(settings, "SOLO_CACHE_PREFIX", solo_settings.SOLO_CACHE_PREFIX) | |||
| return f"{prefix}:{cls.__name__.lower()}" | |||
There was a problem hiding this comment.
Could you add a comment here that explains why we include cls.__module__?
johnthagen
requested changes
Oct 7, 2024
johnthagen
approved these changes
Oct 7, 2024
|
@ahumeau Thank you for your contribution. |
|
My pleasure, thanks for your work maintaining this project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two models with the same name in different apps would previously get the same cache key.
Including the model's module in the cache key fixes this.