Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZoneOffsetAdapter is not used #6

Closed
martinsefcik opened this issue Dec 5, 2016 · 1 comment
Closed

ZoneOffsetAdapter is not used #6

martinsefcik opened this issue Dec 5, 2016 · 1 comment
Assignees
Labels

Comments

@martinsefcik
Copy link

ZoneOffset is subclass of ZoneId so it is means that ZoneOffsetAdapter is never used (ZoneIdAdapter is always used for objects of ZoneId and ZoneOffset type)
So the following two if statements should be in reverted order. (ZoneOffset first)

} else if (obj instanceof ZoneId) {
            return new ZoneIdAdapter((ZoneId) obj);
        } else if (obj instanceof ZoneOffset) {
            return new ZoneOffsetAdapter((ZoneOffset) obj);
}
@lazee lazee added the bug label Dec 15, 2016
@lazee lazee self-assigned this Dec 15, 2016
lazee added a commit that referenced this issue Dec 15, 2016
@lazee
Copy link
Owner

lazee commented Dec 15, 2016

Thnx @martinsefcik !

I had some serious issues with releasing to Nexus tonight. Hence the two releases (1.1.3 and 1.1.4). The fix is in version 1.1.4 which will be available in the central repo within a few hours.

@lazee lazee closed this as completed Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants