Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pattern matching in clustree.data.frame #19

Closed
lazappi opened this issue Aug 1, 2018 · 0 comments
Closed

Pattern matching in clustree.data.frame #19

lazappi opened this issue Aug 1, 2018 · 0 comments

Comments

@lazappi
Copy link
Owner

lazappi commented Aug 1, 2018

grepl is used to match data.frame columns with clustering information. If the prefix contains a wildcard character (e.g. ".") that can lead to matching incorrect columns.

A simple solution would be to add fixed = TRUE.

grepl(prefix, colnames(x), fixed = TRUE)
lazappi added a commit that referenced this issue Jan 29, 2020
@lazappi
Change prefix matching to use regex
600f2a5 
Fixes some problems but undoes the fix to #19...
lazappi added a commit that referenced this issue Jan 29, 2020
@lazappi
Change prefix matching to simpler exact method
cd04a2a 
Should match start of column names without running into #19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lazappi