Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update factory.go #59

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Update factory.go #59

merged 1 commit into from
Nov 3, 2022

Conversation

PCD-01
Copy link

@PCD-01 PCD-01 commented Nov 3, 2022

No description provided.

@lycorisor lycorisor merged commit 8404204 into layou233:master Nov 3, 2022
@lycorisor
Copy link
Collaborator

thanks

@layou233
Copy link
Owner

layou233 commented Nov 4, 2022

感谢!
这个 bug 我最早应该在 #52 (comment) 观察到了,当时没想出是哪里的问题,看来社区的 review 还是非常重要啊😂
另外,建议及时更新 Go 版本,每次 Go 更新都能给我带来惊喜,并且我会尽可能地使我的代码跟进最新 Go 版本的 API 调整。比如目前 ZBProxy 已经将最低支持版本改为 go1.18 了,并且以后会随着依赖的更新 (thanks @dependabot) 改为更高的版本。
事实上,此行代码在更改之后不需要用 GetSecond 了(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants