-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Penambahan fitur bagi pengguna terdaftar #12
Conversation
Wah, padahal saya baru saja mau rilis versi 0.4.0 😅. Terima kasih! Saya coba tinjau dulu, ya. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kerja bagus, keren sekali! Saya belum sempat mencobanya sih, tetapi melihat kodenya sekilas, sepertinya sudah cukup baik. Ini hasil tinjauan pertama saya.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terima kasih sudah merevisi PR ini. Berikut hasil tinjauan kedua saya.
- etimologi - kata turunan - gabungan kata - peribahasa
- Gunakan `pathlib.Path` daripada `os.path` - Buat class utama untuk Galat - Ubah bagian "lain-lain"
Antisipasi jika ada atribut yang tidak lengkap Format juga sedikit diubah agar lebih sesuai dengan situs asli
Kuki tetap digunakan dan batas pencarian tetap lebih besar
Hanya terjadi jika terautentikasi
Relevan: #8 (fix #8)
Contoh
KBBI('roh', email="REDACTED", password="REDACTED")
KBBI('coba', email="REDACTED", password="REDACTED")
Mungkin nanti bisa diganti beberapa variabelnya