Set showModal=false on modal stories #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://main--600c295ccb36300021e7d82f.chromatic.com/?path=/docs/components-organisms-modal--docs does not show the documentation for the modals because the modals are opening on component-render, but there's one that can't be closed -- so user can _never_ see the modal documentation page
ickas
approved these changes
Oct 24, 2023
hvasconcelos
pushed a commit
that referenced
this pull request
Oct 24, 2023
* Set showModal=false on modal stories (#125) * Set showModal=false on modal stories https://main--600c295ccb36300021e7d82f.chromatic.com/?path=/docs/components-organisms-modal--docs does not show the documentation for the modals because the modals are opening on component-render, but there's one that can't be closed -- so user can _never_ see the modal documentation page * set showModal=false on modal-drawer stories as well * [TKAI-3423] chore: add deposit and withdraw icons (#126) * chore: don't hide the button when opening the modal * chore: improve modal simple story * style: add new deposit and withdraw icons --------- Co-authored-by: moshmage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://main--600c295ccb36300021e7d82f.chromatic.com/?path=/docs/components-organisms-modal--docs
does not show the documentation for the modals because the modals are opening on component-render, but there's one that can't be closed -- so user can never see the modal documentation page