Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Checkbox and Field with button #123

Merged
merged 12 commits into from
Sep 22, 2023
Merged

[Fix] Checkbox and Field with button #123

merged 12 commits into from
Sep 22, 2023

Conversation

RTAndrew
Copy link
Collaborator

@RTAndrew RTAndrew commented Sep 21, 2023 •
edited
Loading

  • The checkbox component was transformed into a controlled component, which the stylings were catching with the previous uncontrolled component.
  • For some reason the field with button was not updating as the value prop changes. So putting a useEffect on it solves the issue.

@RTAndrew RTAndrew requested a review from ickas September 21, 2023 23:16
@ickas ickas merged commit 8136cc0 into develop Sep 22, 2023
0 of 5 checks passed
@ickas ickas deleted the akl_fix_checkbox_and_field_with_button branch September 22, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ickas ickas ickas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RTAndrew @ickas