[chore] Fixes invalid semantic error #69
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
Currently, when a new meshmap snapshot workflow is added, then it replaces
ph_filePath
with<file-path>
.Now the issue is that
${{ inputs.fileName == '' && $ph_filePath || inputs.fileName }}
resolves to${{ inputs.fileName == '' && <file-path> || inputs.fileName }}
which is semantically incorrect as<file-path>
is treated as variable instead of a string.So, this PR updates the template workflow file to ensure on replacement the line resolves to
${{ inputs.fileName == '' && '<file-path>' || inputs.fileName }}
.This would also fix: https://github.com/meshery/meshery/actions/runs/7268615022
This PR fixes #