Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update action.yml #36

Merged
merged 1 commit into from
Jun 25, 2023
Merged

Conversation

theBeginner86
Copy link
Contributor

Notes for Reviewers

This PR updates the Meshery Cloud endpoint for Catalog Applications

Relates to https://github.com/layer5io/meshery-cloud/pull/1001

This PR fixes #

  • Yes, I signed my commits.

@theBeginner86
Copy link
Contributor Author

@Abhishek-kumar09
Would you please merge this PR?

I'll make a Meshery Cloud release then.

Copy link
Contributor

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Contributor

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theBeginner86 isn’t this endpoint backwards? According to the endpoint grouping in the Meshery cloud APi endpoints spreadsheet, content comes before catalog.

@leecalcote leecalcote merged commit 8a611dd into layer5labs:master Jun 25, 2023
@theBeginner86
Copy link
Contributor Author

@theBeginner86 isn’t this endpoint backwards? According to the endpoint grouping in the Meshery cloud APi endpoints spreadsheet, content comes before catalog.

No, the structure of endpoints is /catalog/content/<type>.
Hence it is inline with the backend endpoints.

Screenshot 2023-06-25 at 3 23 29 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants