Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Resolution and Direct to Meshery cloud page #14

Merged
merged 6 commits into from
Jun 1, 2023
Merged

Increase Resolution and Direct to Meshery cloud page #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2cd9b1c
Extend the resolution to 1920*1080
Abhishek-kumar09 Jun 1, 2023
446f221
direct to the meshery-cloud catalog page
Abhishek-kumar09 Jun 1, 2023
071ff04
direct to the meshery-cloud catalog page
Abhishek-kumar09 Jun 1, 2023
c169d50
put the PR reference dynamically
Abhishek-kumar09 Jun 1, 2023
196dc77
Update cypress-action/cypress/support/commands.js
Abhishek-kumar09 Jun 1, 2023
94abae2
minor
Abhishek-kumar09 Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/pr-target-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ jobs:
continue-on-error: true
name: Run the MeshMap screenshot service
steps:
- name: Set PR number
run: |
export pull_number=$(jq --raw-output .pull_request.number "$GITHUB_EVENT_PATH")
echo "PULL_NO=$pull_number" >> $GITHUB_ENV
- uses: actions/checkout@v3
- id: test_result
uses: ./
Expand All @@ -22,4 +26,4 @@ jobs:
providerToken: ${{ secrets.PROVIDER_TOKEN }}
cypressRecordKey: ${{ secrets.CYPRESS_RECORD_KEY }}
applicationId: c791ec8f-ec1a-47c1-b606-d39982e42ca6
prNumber: 11
prNumber: ${{ env.PULL_NO }}
6 changes: 5 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ jobs:
test: # make sure the action works on a clean machine without building
runs-on: ubuntu-latest
steps:
- name: Set PR number
run: |
export pull_number=$(jq --raw-output .pull_request.number "$GITHUB_EVENT_PATH")
echo "PULL_NO=$pull_number" >> $GITHUB_ENV
- uses: actions/checkout@v3
- id: test_result
uses: ./
Expand All @@ -20,4 +24,4 @@ jobs:
providerToken: ${{ secrets.PROVIDER_TOKEN }}
cypressRecordKey: ${{ secrets.CYPRESS_RECORD_KEY }}
applicationId: c791ec8f-ec1a-47c1-b606-d39982e42ca6
prNumber: 11
prNumber: ${{ env.PULL_NO }}
4 changes: 2 additions & 2 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,5 +121,5 @@ runs:
repository: "${{env.ORGANIZATION}}/${{env.REPOSITORY}}"
number: ${{ inputs.prNumber }}
id: meshmap-snapshot
message: "![github-ss](${{env.RESOURCE_URL}})"
append: false
message: '[<img src="${{env.RESOURCE_URL}}">](https://meshery.layer5.io/catalog/applications)'
append: false
2 changes: 1 addition & 1 deletion cypress-action/cypress/support/commands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ Cypress.Commands.add("interceptCapabilities", () => {
})

Cypress.Commands.add("setViewPort", () => {
cy.viewport(1500, 900)
cy.viewport(1600, 950)
})

Cypress.Commands.add("deleteDesign", (designId) => {
Expand Down