Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Executive Bio to member profile #2931

Merged
merged 7 commits into from
Jul 19, 2022
Merged

Added Executive Bio to member profile #2931

merged 7 commits into from
Jul 19, 2022

Conversation

debo19
Copy link
Member

@debo19 debo19 commented Jun 25, 2022 •
edited
Loading

Signed-off-by: Debopriya Bhattacharjee [email protected]

Description

Screen.Recording.2022-06-26.at.2.29.05.AM.mov

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

executive bio
7218990 
Signed-off-by: Debopriya Bhattacharjee <[email protected]>
@debo19 debo19 requested a review from leecalcote June 25, 2022 21:32
@leecalcote
Copy link
Member

@debo19 the recorded demo looks great. If the activated modal can be referenced by URL, I will put the URL to use. Can the photo in the modal be a different, second photo?

@debo19
Copy link
Member Author

debo19 commented Jun 25, 2022

@leecalcote Yes, the photo can be different. About the url, I'll try to figure it out.

leecalcote
leecalcote reviewed Jun 27, 2022
View reviewed changes
src/collections/members/lee-calcote/index.mdx
@@ -19,4 +19,13 @@ badges:
location: Austin, Texas, USA
bio: "Lee Calcote is an innovative product and technology leader, passionate about empowering engineers and enabling organizations. As Founder of Layer5, he is at the forefront of the cloud native movement. Open source, advanced and emerging technologies have been a consistent focus through Calcote’s time at SolarWinds, Seagate, Cisco and Schneider Electric. An advisor, author, and speaker, Calcote is active in the community as a Docker Captain, Cloud Native Ambassador and GSoC, GSoD, and LFX Mentor."
published: true
executive_bio: available
executive_position: Founder and CEO
company: Layer5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to define executive_photo here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avert your eyes first, but here's the second photo for use in the executive bio - https://blog.gingergeek.com/wp-content/uploads/2019/11/Lee-Calcote.jpg

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use this second photo in the alternative bio

Debopriya Bhattacharjee added 2 commits July 3, 2022 01:29
added image
346bc59 
Signed-off-by: Debopriya Bhattacharjee <[email protected]>
fix
b313eeb 
Signed-off-by: Debopriya Bhattacharjee <[email protected]>
@debo19
Copy link
Member Author

debo19 commented Jul 2, 2022

@Nikhil-Ladha @warunicorn19 do you know why the build is failing?

@Nikhil-Ladha
Copy link
Contributor

Is it getting built locally?

warunicorn19
warunicorn19 suggested changes Jul 3, 2022
View reviewed changes
src/sections/app.style.js
overflow: hidden;
width: 140px;
height: 140px;
box-shadow: 0px 0px 8px 1px rgba(0,179,159,1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please not hard code the color here.

src/sections/Community/Member-single/memberSingle.style.js
@@ -131,6 +134,10 @@ export const MemberSingleWrapper = styled.div`
.twitter{
color: #1DA1F2;
}
.bio{
color: #00b39f;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a color from the theme.

@debo19
Copy link
Member Author

debo19 commented Jul 3, 2022

Is it getting built locally?

Yup it does

@Nikhil-Ladha
Copy link
Contributor

Is it getting built locally?

Yup it does

I am asking about make build not make site.

@debo19
Copy link
Member Author

debo19 commented Jul 3, 2022 •
edited
Loading

I am asking about make build not make site.

Yeah both of them are working fine locally.

@Nikhil-Ladha
Copy link
Contributor

I am asking about make build not make site.

Yeah both of them are working fine locally.

Ok
In that case, I think the react-modal library is making the bundle heavy and leading to a memory crash. Can you try making a commit with the Modal component commented out, and see if that allows the build process or not?

commment
cefde67 
Signed-off-by: Debopriya Bhattacharjee <[email protected]>
@leecalcote
Copy link
Member

If the individually published page is too much of a pain in the rump, we can forego it for now, until the exec team is larger.

debo19 and others added 3 commits July 18, 2022 03:16
@debo19
Merge branch 'master' into executive_blog
5d131b7
seperate component
ee6fab7 
Signed-off-by: Debopriya Bhattacharjee <[email protected]>
minor change
edb6f2d 
Signed-off-by: Debopriya Bhattacharjee <[email protected]>
@warunicorn19 warunicorn19 merged commit ed9a141 into layer5io:master Jul 19, 2022
@debo19 debo19 mentioned this pull request Jul 19, 2022
Merged
@debo19 debo19 deleted the executive_blog branch August 16, 2022 19:18
@Jamir2412 Jamir2412 mentioned this pull request Apr 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote left review comments

@warunicorn19 warunicorn19 warunicorn19 requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@debo19 @leecalcote @Nikhil-Ladha @warunicorn19