Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added VMware logo #2905

Merged
merged 4 commits into from
Jun 23, 2022
Merged

Conversation

subhradwip01
Copy link
Contributor

Description

VMWare Logo has been added to layer5.io 's second section

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Jun 12, 2022

🚀 Preview for commit 975ee34 at: https://62a5d1fc1ffcb3554f50aadd--layer5.netlify.app

@YashKamboj
Copy link
Contributor

@subhradwip01 I am not sure about the design change 🤔

@subhradwip01
Copy link
Contributor Author

@subhradwip01 I am not sure about the design change 🤔

Actually I changed the design little bit because if don't do this vmware logo will go on the top of layer5 cards that are present on the banner..it will be not so visible in that case..that's why I just do flex wrap..

@YashKamboj
Copy link
Contributor

YashKamboj commented Jun 12, 2022

@subhradwip01 Let's discuss it in tomorrow's websites meeting and get everyone's opinion on it

@leecalcote
Copy link
Member

It's ok for the logos to overlap the cards. That design is intentional.

@Nikhil-Ladha
Copy link
Contributor

@subhradwip01 please revert the design change.
@leecalcote do we want to add VMware to the partner's page as well? If so, can you please add some context that needs to be added alongside?

@subhradwip01
Copy link
Contributor Author

@subhradwip01 please revert the design change. @leecalcote do we want to add VMware to the partner's page as well? If so, can you please add some context that needs to be added alongside?

Ok..If you want to add the text also, just give me some context I will add it

@l5io
Copy link
Contributor

l5io commented Jun 16, 2022

🚀 Preview for commit df36aec at: https://62aae1e19e21a6501b2bb42e--layer5.netlify.app

@subhradwip01
Copy link
Contributor Author

@Nikhil-Ladha could check it once?

Copy link
Contributor

@YashKamboj YashKamboj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@subhradwip01 The logos are cropped, try decreasing the spacing between the logos (don't commit ,share a screenshot first to check)
Screenshot (115)

@Nikhil-Ladha
Copy link
Contributor

@subhradwip01 The logos are cropped, try decreasing the spacing between the logos (don't commit ,share a screenshot first to check) Screenshot (115)

That's intentional, and can be ignored.

@subhradwip01
Copy link
Contributor Author

@Nikhil-Ladha ok...and should I add VMware to the partner's page as well? If so, can you please add some context that needs to be added alongside?

@Nikhil-Ladha
Copy link
Contributor

@Nikhil-Ladha ok...and should I add VMware to the partner's page as well? If so, can you please add some context that needs to be added alongside?

Let's get it merged, if need be the context can be added later on.

@Nikhil-Ladha Nikhil-Ladha merged commit 389453c into layer5io:master Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants