-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added VMware logo #2905
Added VMware logo #2905
Conversation
Signed-off-by: subhradwip01 <[email protected]>
🚀 Preview for commit 975ee34 at: https://62a5d1fc1ffcb3554f50aadd--layer5.netlify.app |
@subhradwip01 I am not sure about the design change 🤔 |
Actually I changed the design little bit because if don't do this vmware logo will go on the top of layer5 cards that are present on the banner..it will be not so visible in that case..that's why I just do flex wrap.. |
@subhradwip01 Let's discuss it in tomorrow's websites meeting and get everyone's opinion on it |
It's ok for the logos to overlap the cards. That design is intentional. |
@subhradwip01 please revert the design change. |
Ok..If you want to add the text also, just give me some context I will add it |
Signed-off-by: subhradwip01 <[email protected]>
🚀 Preview for commit df36aec at: https://62aae1e19e21a6501b2bb42e--layer5.netlify.app |
@Nikhil-Ladha could check it once? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@subhradwip01 The logos are cropped, try decreasing the spacing between the logos (don't commit ,share a screenshot first to check)
That's intentional, and can be ignored. |
@Nikhil-Ladha ok...and should I add VMware to the partner's page as well? If so, can you please add some context that needs to be added alongside? |
Let's get it merged, if need be the context can be added later on. |
Description
VMWare Logo has been added to layer5.io 's second section
Notes for Reviewers
Signed commits