Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Responsiveness of first hero banner #2888

Merged
merged 6 commits into from
Jun 10, 2022
Merged

[Fix] Responsiveness of first hero banner #2888

merged 6 commits into from
Jun 10, 2022

Conversation

VaibhavArora19
Copy link
Contributor

@VaibhavArora19 VaibhavArora19 commented Jun 9, 2022 •
edited
Loading

Signed-off-by: Vaibhav Arora [email protected]

Description

This PR fixes #2868

Current Behaviour
Layer5

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@leecalcote
Copy link
Member

Building preview..

@l5io
Copy link
Contributor

l5io commented Jun 9, 2022

🚀 Preview for commit d89d378 at: https://62a1e0fe293a1a70555d3eee--layer5.netlify.app

@leecalcote
Copy link
Member

Screen Shot 2022-06-09 at 8 42 06 AM

Will you kindly address the overlapping in this other banner version, too?

@leecalcote
Copy link
Member

@VaibhavArora19 I'm hopeful that you can find a way to get the "of developer-defined infrastructure" to stay on a single line by adjusting margins (not using white-space: nowrap;)

@VaibhavArora19
Copy link
Contributor Author

I think that will make the text too small considering for every screen size!

@leecalcote
Copy link
Member

I think that will make the text too small considering for every screen size!

Humor me.

@leecalcote leecalcote added the kind/chore Necessary task label Jun 9, 2022
@VaibhavArora19
Copy link
Contributor Author

sc

Will that work?

@l5io
Copy link
Contributor

l5io commented Jun 9, 2022

🚀 Preview for commit aac169d at: https://62a237a8e2278b1cc43d774b--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Jun 9, 2022

🚀 Preview for commit 6fd158c at: https://62a2563c58a87003c27d1045--layer5.netlify.app

@leecalcote
Copy link
Member

Yes, that'll work. As of the last deployment preview, the same issues are still present with both the first and second banner.

@VaibhavArora19
Copy link
Contributor Author

@leecalcote can you check now?

@l5io
Copy link
Contributor

l5io commented Jun 10, 2022

🚀 Preview for commit 28692f3 at: https://62a36464d4616f5f9f77c5ce--layer5.netlify.app

leecalcote
leecalcote approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You nailed it, @VaibhavArora19 👏

@leecalcote leecalcote merged commit f1c2c8f into layer5io:master Jun 10, 2022
@VaibhavArora19 VaibhavArora19 deleted the responsive branch June 10, 2022 16:28
@VaibhavArora19
Copy link
Contributor Author

You nailed it, @VaibhavArora19 👏

Thank you!😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote approved these changes

Assignees
No one assigned
Labels
kind/chore Necessary task
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Hero] Responsiveness of first hero banner
3 participants
@VaibhavArora19 @leecalcote @l5io