Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rotational CTA framework #2866

Merged
merged 6 commits into from
Jun 13, 2022

Conversation

Nikhil-Ladha
Copy link
Contributor

@Nikhil-Ladha Nikhil-Ladha commented Jun 6, 2022

Signed-off-by: Nikhil-Ladha [email protected]

Description
Added the rotational CTA framework for MDX content.
Any MDX file can have these CTA's, explicit import is not required. Just
write the component that you want to have and it will render.

The bottom CTA is added to the MDXProvider, but for blogs it is
imported under the blog-single code, because of the position at which
we want the CTA to be present.

This PR fixes #2848

Signed commits

  • Yes, I signed my commits.

@Nikhil-Ladha Nikhil-Ladha added the pr/hold Do not merge this PR label Jun 6, 2022
@Nikhil-Ladha Nikhil-Ladha requested a review from leecalcote June 6, 2022 16:43
@Nikhil-Ladha
Copy link
Contributor Author

@leecalcote I have added the CTA's to one blog post for reference. If all looks good, signal here so that I will comment them out and update the code.

@l5io
Copy link
Contributor

l5io commented Jun 6, 2022

🚀 Preview for commit a5b0044 at: https://629e30f27ea53561cc69c5af--layer5.netlify.app

@Nikhil-Ladha
Copy link
Contributor Author

Signed-off-by: leecalcote <[email protected]>
@leecalcote
Copy link
Member

leecalcote commented Jun 9, 2022

The CTA button doesn't seem to want to do what it's told (just like my second son).

Screen Shot 2022-06-08 at 7 29 49 PM

.

@l5io
Copy link
Contributor

l5io commented Jun 9, 2022

🚀 Preview for commit 28451c0 at: https://62a14243bd26d124a2e87815--layer5.netlify.app

@Nikhil-Ladha
Copy link
Contributor Author

Done with responsiveness.
I think the rest looks good, and the CTA's can be removed and PR merged?

@l5io
Copy link
Contributor

l5io commented Jun 9, 2022

🚀 Preview for commit 3adb70b at: https://62a226f9af3a650443968c72--layer5.netlify.app

@Nikhil-Ladha
Copy link
Contributor Author

Considering, that we are good with this.....merging the PR.

@l5io
Copy link
Contributor

l5io commented Jun 13, 2022

🚀 Preview for commit 6df6046 at: https://62a6d1c0552b2d6b5c719416--layer5.netlify.app

@Nikhil-Ladha Nikhil-Ladha removed the pr/hold Do not merge this PR label Jun 13, 2022
@Nikhil-Ladha
Copy link
Contributor Author

@leecalcote added support for categorizing CTA's, using a category prop.
And, for convenience, I have also added a sweet little README for anyone wondering how to use it.

@l5io
Copy link
Contributor

l5io commented Jun 13, 2022

🚀 Preview for commit 587cb84 at: https://62a759ce21ada505f8c3041d--layer5.netlify.app

@Nikhil-Ladha Nikhil-Ladha merged commit 8b3985f into layer5io:master Jun 13, 2022
@Nikhil-Ladha Nikhil-Ladha deleted the rotational_cta branch June 13, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Rotational Call-to-Action Framework
3 participants