fix hover effect #316
Merged
fix hover effect #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rajiv <[email protected]>
✅ Website preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The hover effect is not shown on the slack icon @Rajivkumawat3 ! |
|
@Rajivkumawat3 this is the preview link: https://deploy-preview-316--getnighthawk.netlify.app/ |
|
@Rajivkumawat3 Please take the reference from https://github.com/meshery/meshery.io |
vishalvivekm
requested changes
Jul 2, 2023
| @@ -22,7 +22,7 @@ | |||
| {% when "DockerHub" %} | |||
| <svg height="512px" style="enable-background:new 0 0 512 512;" version="1.1" viewBox="0 0 512 512" width="512px" xml:space="preserve" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"><g id="comp_x5F_97-docker"><g><rect height="43.193" width="47.506" x="229.999" y="147.225"/><rect height="42.69" width="47.506" x="229.999" y="199.115"/><rect height="43.193" width="47.506" x="173.869" y="147.225"/><rect height="42.691" width="47.507" x="286.2" y="199.043"/><rect height="43.625" width="47.506" x="229.999" y="94.975"/><rect height="43.193" width="47.505" x="117.738" y="147.225"/><rect height="42.691" width="47.506" x="173.869" y="199.043"/><path d="M476.441,219.095c-10.35-6.972-34.21-9.487-52.537-6.036c-2.371-17.249-12.003-32.27-29.538-45.782l-10.062-6.685 l-6.685,10.062c-13.225,19.98-16.817,52.896-2.658,74.602c-6.252,3.377-18.545,7.978-34.786,7.689H27.757 c-6.252,36.511,4.169,83.945,31.624,116.501c26.663,31.551,66.623,47.579,118.872,47.579c113.124,0,196.851-52.104,236.021-146.76 c15.381,0.288,48.584,0.073,65.618-32.483c1.078-1.797,4.743-9.488,6.107-12.291L476.441,219.095z"/><polygon points="109.186,199.043 109.113,199.043 61.68,199.043 61.68,241.734 109.186,241.734 "/><rect height="42.691" width="47.505" x="117.738" y="199.043"/></g></g><g id="Layer_1"/></svg> | |||
| {% when "Slack"%} | |||
| <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" width="24px" height="24px"><path d="M9,7C8.359,7,4.639,7,4,7C2.895,7,2,7.895,2,9c0,1.105,0.895,2,2,2c0.639,0,4.359,0,5,0c1.105,0,2-0.895,2-2 C11,7.895,10.105,7,9,7z"/><path d="M11,4c0,0.598,0,2,0,2S9.507,6,9,6C7.895,6,7,5.105,7,4s0.895-2,2-2S11,2.895,11,4z"/><path d="M7,14c0,0.641,0,4.361,0,5c0,1.105,0.895,2,2,2c1.105,0,2-0.895,2-2c0-0.639,0-4.359,0-5c0-1.105-0.895-2-2-2 C7.895,12,7,12.895,7,14z"/><path d="M4,12c0.598,0,2,0,2,0s0,1.493,0,2c0,1.105-0.895,2-2,2s-2-0.895-2-2S2.895,12,4,12z"/><path d="M14,16c0.641,0,4.361,0,5,0c1.105,0,2-0.895,2-2c0-1.105-0.895-2-2-2c-0.639,0-4.359,0-5,0c-1.105,0-2,0.895-2,2 C12,15.104,12.895,16,14,16z"/><path d="M12,19c0-0.598,0-2,0-2s1.493,0,2,0c1.105,0,2,0.895,2,2c0,1.105-0.895,2-2,2S12,20.104,12,19z"/><path d="M16,9c0-0.641,0-4.361,0-5c0-1.105-0.895-2-2-2c-1.105,0-2,0.895-2,2c0,0.639,0,4.359,0,5c0,1.105,0.895,2,2,2 C15.104,11,16,10.104,16,9z"/><path d="M19,11c-0.598,0-2,0-2,0s0-1.493,0-2c0-1.105,0.895-2,2-2c1.105,0,2,0.895,2,2S20.104,11,19,11z"/></svg> | |||
| <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" width="24px" height="24px"><path d="M9,7C8.359,7,4.639,7,4,7C2.895,7,2,7.895,2,9c0,1.105,0.895,2,2,2c0.639,0,4.359,0,5,0c1.105,0,2-0.895,2-2 C11,7.895,10.105,7,9,7z" fill="grey" class="first"/><path d="M11,4c0,0.598,0,2,0,2S9.507,6,9,6C7.895,6,7,5.105,7,4s0.895-2,2-2S11,2.895,11,4z" fill="grey" class="second"/><path d="M7,14c0,0.641,0,4.361,0,5c0,1.105,0.895,2,2,2c1.105,0,2-0.895,2-2c0-0.639,0-4.359,0-5c0-1.105-0.895-2-2-2 C7.895,12,7,12.895,7,14z" fill="grey" class="third"/><path d="M4,12c0.598,0,2,0,2,0s0,1.493,0,2c0,1.105-0.895,2-2,2s-2-0.895-2-2S2.895,12,4,12z" fill="grey" class="fourth"/><path d="M14,16c0.641,0,4.361,0,5,0c1.105,0,2-0.895,2-2c0-1.105-0.895-2-2-2c-0.639,0-4.359,0-5,0c-1.105,0-2,0.895-2,2 C12,15.104,12.895,16,14,16z" fill="grey" class="fifth"/><path d="M12,19c0-0.598,0-2,0-2s1.493,0,2,0c1.105,0,2,0.895,2,2c0,1.105-0.895,2-2,2S12,20.104,12,19z" fill="grey" class="sixth"/><path d="M16,9c0-0.641,0-4.361,0-5c0-1.105-0.895-2-2-2c-1.105,0-2,0.895-2,2c0,0.639,0,4.359,0,5c0,1.105,0.895,2,2,2 C15.104,11,16,10.104,16,9z" fill="grey" class="seventh"/><path d="M19,11c-0.598,0-2,0-2,0s0-1.493,0-2c0-1.105,0.895-2,2-2c1.105,0,2,0.895,2,2S20.104,11,19,11z" fill="grey" class="eighth"/></svg> | |||
There was a problem hiding this comment.
Why is there a need of new svg ? @Rajivkumawat3
There was a problem hiding this comment.
sir it is not new svg , i uppdate current svg ,gave class to each path to fill color of slack-icon
Nighthawk._.The.Nighthawk.distribution.for.service.mesh.performance.characterization.Integrating.Meshery.and.Service.Mesh.Performance.-.Google.Chrome.2023-07-02.20-18-23.mp4 |
Signed-off-by: Rajiv <[email protected]>
|
@vishalvivekm sir check now working fine |
vishalvivekm
approved these changes
Jul 2, 2023
|
Let's discuss this on the Websites call. Please add this as an agenda item in the meeting minutes @Rajivkumawat3 |
|
ok sir |
Chadha93
suggested changes
Jul 18, 2023
There was a problem hiding this comment.
@Rajivkumawat3 In the deploy preview, the Twitter icon is disabled, and icons are of different sizes. These items require an update.
|
@Chadha93 sir twitter icon is not disable , in deploy preview it's working fine |
|
Thanks for your contribution to the Layer5 community! 🎉
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #311
Notes for Reviewers
Signed commits