-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore:Added responsive Navbar #240
Conversation
Signed-off-by: anirudh-bukka <[email protected]>
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
✔️ Website preview ready! 🔨 Explore the source changes: 1f6dd22 🔍 Inspect the deploy log: https://app.netlify.com/sites/getnighthawk/deploys/61ebac81fc78310007453a60 😎 Browse the preview: https://deploy-preview-240--getnighthawk.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anirudh-bukka great work, it looks good for mobile view, just do the same changes for tab view as well ( max-width: 768px) and in that screen size try to shift nav icon bit towards right
you can also take reference from this article if you want to read more about media queries: https://www.geeksforgeeks.org/how-to-target-desktop-tablet-and-mobile-using-media-query/
On it |
Signed-off-by: anirudh-bukka <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 , great work @anirudh-bukka
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anirudh-bukka Good Work!!! just one small thing , i the "menu" written after the icon is removed ,so if you bring that back would be great .
Thanks @YashKamboj , But I felt, having the word 'menu' would make the navbar cluttered and congested. What do you say? |
Thanks @Abhijay007 ! |
I guess it will look great even without menu written |
Might be better toh have just the nighthawk logo in smaller views than the text logo. What do you think @debo19 |
@anirudh-bukka @YashKamboj @warunicorn19 The UI/UX Convention is not to have a title saying |
@adithyaakrishna the title |
My bad xD, I didnt see that :( |
@warunicorn19 It might look too empty though.🤔 I think this looks fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉 Thanks @anirudh-bukka
Thanks @Abhijay007 for helping me in all the set-up and pushing my first pr! |
Signed-off-by: anirudh-bukka [email protected]
Description
This PR fixes #189
Notes for Reviewers
Added hover effects and corrected the position of the drop down menu list from the hamburger button.
Signed commits