Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[site] image container size to 50% #238

Merged
merged 6 commits into from
Jan 28, 2022
Merged

[site] image container size to 50% #238

merged 6 commits into from
Jan 28, 2022

Conversation

akshitarora921
Copy link
Contributor

Signed-off-by: Akshit [email protected]

Description
The meshery nighthawk performance chart image is not 50% of its container.

This PR fixes #206

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@akshitarora921
add flex:1
352a09e 
Signed-off-by: Akshit <[email protected]>
@welcome
Copy link

welcome bot commented Jan 20, 2022

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@netlify
Copy link

netlify bot commented Jan 20, 2022 •
edited
Loading

✔️ Website preview ready!

🔨 Explore the source changes: e96bfd0

🔍 Inspect the deploy log: https://app.netlify.com/sites/getnighthawk/deploys/61f395f8de6b370007d75d3c

😎 Browse the preview: https://deploy-preview-238--getnighthawk.netlify.app

Abhijay007
Abhijay007 approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@Abhijay007 Abhijay007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 great work @akshitarora921

YashKamboj
YashKamboj reviewed Jan 20, 2022
View reviewed changes
Copy link

@YashKamboj YashKamboj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshitarora921 I think the photo should come below the description when the screen size decreases , same for the image below , this issue is already there , we can solve it here only . @Abhijay007 views???

Neilblaze
Neilblaze suggested changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@Neilblaze Neilblaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes aren't populating the exact update which needs to be solved #206. Follow this.

@Abhijay007
Copy link
Contributor

Abhijay007 commented Jan 20, 2022 •
edited
Loading

@akshitarora921 I think the photo should come below the description when the screen size decreases , same for the image below , this issue is already there , we can solve it here only . @Abhijay007 views???

ya, this can be solved just need to set flex-direction: column-reserve on styling properties of class .custom-desc-div in smaller screens

@akshitarora921
Copy link
Contributor Author

The changes aren't populating the exact update which needs to be solved #206. Follow this.

This is not in the issue description thanks for pointing it out. I have fixed it by wrapping the data around the container class.

@Abhijay007
Copy link
Contributor

The changes aren't populating the exact update which needs to be solved #206. Follow this.

This is not in the issue description thanks for pointing it out. I have fixed it by wrapping the data around the container class.

@akshitarora921 don't forget to signoff DCO in your next commit :) it is good practice

@akshitarora921
Copy link
Contributor Author

In the VS Code, I have changed the settings but I have made the last commit using github.dev and I forgot to add DCO.

Abhijay007
Abhijay007 approved these changes Jan 22, 2022
View reviewed changes
Copy link
Contributor

@Abhijay007 Abhijay007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Abhijay007 Abhijay007 requested a review from leecalcote January 22, 2022 06:38
YashKamboj
YashKamboj reviewed Jan 22, 2022
View reviewed changes
docs/index.html Outdated
@@ -93,8 +93,7 @@ <h1 class="desc-h1">Nighthawk and Meshery</h1>
</div>
<div class="nighthawk-meshery-div">
<div class="container description-div description-div-grpc">
<div class="custom-desc-div">

<div class="">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshitarora921 why did you removed the class??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not doing anything as it only have one child tag, so display:flex or flex-direction: column-reverse were not making any impact.

@leecalcote leecalcote requested a review from YashKamboj January 26, 2022 20:02
@leecalcote leecalcote requested review from NikhilSharma03 and removed request for leecalcote January 26, 2022 20:03
NikhilSharma03
NikhilSharma03 approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@NikhilSharma03 NikhilSharma03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

adithyaakrishna
adithyaakrishna suggested changes Jan 27, 2022
View reviewed changes
docs/index.html Outdated
@@ -93,8 +93,7 @@ <h1 class="desc-h1">Nighthawk and Meshery</h1>
</div>
<div class="nighthawk-meshery-div">
<div class="container description-div description-div-grpc">
<div class="custom-desc-div">

<div class="">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class="">
<div>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshitarora921 Could you please make the small change as suggested above? Thanks for your contribution 🎉🚀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adithyaakrishna Done

@akshitarora921
remove empty class
e96bfd0 
Signed-off-by: Akshit <[email protected]>
@leecalcote leecalcote merged commit 739a28e into layer5io:master Jan 28, 2022
@leecalcote
Copy link
Member

Yay, @akshitarora921! 🎈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adithyaakrishna adithyaakrishna adithyaakrishna requested changes

@Abhijay007 Abhijay007 Abhijay007 approved these changes

@NikhilSharma03 NikhilSharma03 NikhilSharma03 approved these changes

@Neilblaze Neilblaze Awaiting requested review from Neilblaze

@warunicorn19 warunicorn19 Awaiting requested review from warunicorn19

@YashKamboj YashKamboj Awaiting requested review from YashKamboj

Assignees
No one assigned
Labels
area/website
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Site] Unequal split of image and adjoining description on main page
7 participants
@akshitarora921 @Abhijay007 @leecalcote @adithyaakrishna @Neilblaze @NikhilSharma03 @YashKamboj