Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nighthawk docs #181

Merged
merged 7 commits into from
Sep 23, 2021
Merged

Add Nighthawk docs #181

merged 7 commits into from
Sep 23, 2021

Conversation

pottekkat
Copy link
Contributor

@pottekkat pottekkat commented Sep 23, 2021

Signed-off-by: Navendu Pottekkat [email protected]

Description

This PR adds docs for using Nighthawk, Using GetNighthawk APIs and using Nighthawk with Meshery and SMP to run performance benchmarks.

  • Yes, I signed my commits.

Signed-off-by: Navendu Pottekkat <[email protected]>
@pottekkat pottekkat added area/docs Improvements or additions to documentation pr/draft WIP/Draft pull request labels Sep 23, 2021
@netlify
Copy link

netlify bot commented Sep 23, 2021

✔️ Website preview ready!

🔨 Explore the source changes: 981efd6

🔍 Inspect the deploy log: https://app.netlify.com/sites/getnighthawk/deploys/614ca630ad62390008d63b8c

😎 Browse the preview: https://deploy-preview-181--getnighthawk.netlify.app

@warunicorn19
Copy link
Member

@Amino19 label commenter workflow is failing.

@aminoxix aminoxix mentioned this pull request Sep 23, 2021
1 task
@warunicorn19 warunicorn19 added area/docs Improvements or additions to documentation pr/draft WIP/Draft pull request and removed area/docs Improvements or additions to documentation pr/draft WIP/Draft pull request labels Sep 23, 2021
@pottekkat pottekkat marked this pull request as ready for review September 23, 2021 13:17
@pottekkat pottekkat changed the title [Draft] Add Nighthawk docs Add Nighthawk docs Sep 23, 2021
@pottekkat pottekkat requested review from leecalcote, vinayaksh42 and DelusionalOptimist and removed request for leecalcote September 23, 2021 13:18
@pottekkat
Copy link
Contributor Author

Updated this page: https://deploy-preview-181--getnighthawk.netlify.app/docs

Will add more docs as we update Performance Management docs in Meshery

@leecalcote
Copy link
Member

@Amino19 label commenter workflow is failing.

I went ahead and fixed this workflow.

@leecalcote leecalcote added area/docs Improvements or additions to documentation and removed area/docs Improvements or additions to documentation labels Sep 23, 2021
docs/collections/_docs/building-nighthawk.md Outdated Show resolved Hide resolved
docs/collections/_docs/building-nighthawk.md Outdated Show resolved Hide resolved
bazel build -c opt //:nighthawk
```

# Using the Nighthawk CLI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this section out of the building-nighthawk page into a new page.

docs/collections/_docs/performance-benchmarking.md Outdated Show resolved Hide resolved
docs/collections/_docs/performance-benchmarking.md Outdated Show resolved Hide resolved
- http://localhost:2323
duration: "15s"
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need example of mesheryctl perf apply -f here.

@pottekkat
Copy link
Contributor Author

@leecalcote Made the suggested changes. Good to merge?

@leecalcote leecalcote merged commit dabdc5f into layer5io:master Sep 23, 2021
@pottekkat pottekkat deleted the add-docs/navendu-pottekkat branch September 25, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Improvements or additions to documentation pr/draft WIP/Draft pull request
Development

Successfully merging this pull request may close these issues.

3 participants