Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Added the workflow #180

Merged
merged 2 commits into from
Sep 21, 2021
Merged

[CI] Added the workflow #180

merged 2 commits into from
Sep 21, 2021

Conversation

ruhi09
Copy link
Contributor

@ruhi09 ruhi09 commented Sep 21, 2021

Signed-off-by: ruhi09 [email protected]

Description
This repository has the label commenter workflow.
This PR fixes #176

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: ruhi09 <[email protected]>
@welcome
Copy link

welcome bot commented Sep 21, 2021

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

Copy link
Member

@sayantan1413 sayantan1413 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @ruhi09 🚀. Requested some minor changes then we are good to go!

labeled:
issue:
body: Checking in... it has been awhile since we&#39;ve heard from you on this issue. Are you still working on it? Please let us know and please don&#39;t hesitate to contact a [MeshMate](https://layer5.io/community/meshmates/) or any other [community member](https://layer5.io/community/members) for assistance.
action: open
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

action: open
- name: issue/dco
labeled:
pr:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line no 21

To amend the commits in this PR with your signoff using the instructions provided in the DCO check above. \n\n
To configure your dev environment to automatically signoff on your commits in the future, see [these instructions](https://github.com/meshery/meshery/blob/master/CONTRIBUTING.md#signing-off-on-commits-developer-certificate-of-origin)."
action: open

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aminoxix aminoxix added the area/ci Continuous integration | Build and release label Sep 21, 2021
@ruhi09
Copy link
Contributor Author

ruhi09 commented Sep 21, 2021

@sayantan1413 I have updated the changes, do check and let me know!

Copy link
Member

@sayantan1413 sayantan1413 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @ruhi09 !!

Copy link
Contributor

@aminoxix aminoxix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruhi09: Thanks for your contribution, we really appreciate the valuable time & efforts you made! 🥳

@ruhi09
Copy link
Contributor Author

ruhi09 commented Sep 21, 2021

@Amino19 and @sayantan1413 thank you so much everyone for your support!

Copy link
Member

@warunicorn19 warunicorn19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff @ruhi09, thanks😄

@warunicorn19 warunicorn19 merged commit a74ed67 into layer5io:master Sep 21, 2021
@welcome
Copy link

welcome bot commented Sep 21, 2021

Thanks for your contribution to the Layer5 community! 🎉

Congrats!

@aminoxix aminoxix mentioned this pull request Sep 23, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous integration | Build and release
Development

Successfully merging this pull request may close these issues.

[CI] add label commenter workflow
4 participants