Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added responsive heading and paragraph #169

Merged
merged 3 commits into from
Aug 23, 2021

Conversation

AnshumanDhiman
Copy link
Member

@AnshumanDhiman AnshumanDhiman commented Aug 19, 2021

Added responsive heading and paragraph in the Index page so that when user view in the mobile view heading and paragraph automatically changes to center align

Signed-off-by: AnshumanDhiman [email protected]

Description

This PR fixes #168

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

… user view in the mobile view heading and paragraph automatically changes to center align

Signed-off-by: AnshumanDhiman <[email protected]>
@netlify
Copy link

netlify bot commented Aug 19, 2021

✔️ Website preview ready!

🔨 Explore the source changes: b10104d

🔍 Inspect the deploy log: https://app.netlify.com/sites/getnighthawk/deploys/612385c63a1f3d0007430114

😎 Browse the preview: https://deploy-preview-169--getnighthawk.netlify.app

Copy link
Member

@warunicorn19 warunicorn19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnshumanDhiman good work here, but just a small nitpick, the ratio of the font size of the header compared to the text looks a little weird in mobile view.

Screenshot_20210820-100702

Could you please reduce the size of the header, only for mobile view. I think that'll look better

@AnshumanDhiman
Copy link
Member Author

@AnshumanDhiman good work here, but just a small nitpick, the ratio of the font size of the header compared to the text looks a little weird in mobile view.

Screenshot_20210820-100702

Could you please reduce the size of the header, only for mobile view. I think that'll look better

Ok @warunicorn19 I will update this for mobile view

Signed-off-by: AnshumanDhiman <[email protected]>
Copy link
Member

@warunicorn19 warunicorn19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2021-08-23 at 4 49 58 PM

Seems like you missed one😅, could you please do same to this header too.

Signed-off-by: AnshumanDhiman <[email protected]>
@AnshumanDhiman
Copy link
Member Author

AnshumanDhiman commented Aug 23, 2021

@warunicorn19 @vinayaksh42 I changed the remaining heading. What I saw is that there are many bugs like this when switching to the mobile view so I think we should make an issue I will be working on this...

Copy link
Member

@warunicorn19 warunicorn19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnshumanDhiman Yes, I see the same. Could you create an issue for it? For now this PR looks good.

Copy link
Member

@vinayaksh42 vinayaksh42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @AnshumanDhiman, also it would be nice to open up a new issue for mobile view related issues

@vinayaksh42 vinayaksh42 merged commit b20c137 into layer5io:master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

[Site] Mobile responsiveness for Home page
3 participants