-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added responsive heading and paragraph #169
Conversation
… user view in the mobile view heading and paragraph automatically changes to center align Signed-off-by: AnshumanDhiman <[email protected]>
✔️ Website preview ready! 🔨 Explore the source changes: b10104d 🔍 Inspect the deploy log: https://app.netlify.com/sites/getnighthawk/deploys/612385c63a1f3d0007430114 😎 Browse the preview: https://deploy-preview-169--getnighthawk.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnshumanDhiman good work here, but just a small nitpick, the ratio of the font size of the header compared to the text looks a little weird in mobile view.
Could you please reduce the size of the header, only for mobile view. I think that'll look better
Ok @warunicorn19 I will update this for mobile view |
Signed-off-by: AnshumanDhiman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: AnshumanDhiman <[email protected]>
@warunicorn19 @vinayaksh42 I changed the remaining heading. What I saw is that there are many bugs like this when switching to the mobile view so I think we should make an issue I will be working on this... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnshumanDhiman Yes, I see the same. Could you create an issue for it? For now this PR looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @AnshumanDhiman, also it would be nice to open up a new issue for mobile view related issues
Added responsive heading and paragraph in the Index page so that when user view in the mobile view heading and paragraph automatically changes to center align
Signed-off-by: AnshumanDhiman [email protected]
Description
This PR fixes #168
Notes for Reviewers
Signed commits