Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site] Fixed Docs Section 1/Overview Responsiveness #160

Merged
merged 1 commit into from
Aug 12, 2021
Merged

[Site] Fixed Docs Section 1/Overview Responsiveness #160

merged 1 commit into from
Aug 12, 2021

Conversation

NikhilSharma03
Copy link
Member

Signed-off-by: Nikhil Sharma [email protected]

Description

  • There were some responsive issues in the docs section 1/overview page

Screenshot

Screenshot from 2021-08-11 16-44-21

Screenshot from 2021-08-11 16-44-26

Screenshot from 2021-08-11 16-44-32

After Changes

Screenshot from 2021-08-11 16-44-38

Screenshot from 2021-08-11 16-44-49

Screenshot from 2021-08-11 16-44-55

Notes for Reviewers

  • Let me know if there are any other changes we can make.

Signed commits

  • Yes, I signed my commits.

@netlify
Copy link

netlify bot commented Aug 11, 2021

✔️ Website preview ready!

🔨 Explore the source changes: fd5562a

🔍 Inspect the deploy log: https://app.netlify.com/sites/getnighthawk/deploys/6113b33769bd5d000989b756

😎 Browse the preview: https://deploy-preview-160--getnighthawk.netlify.app

Copy link
Member

@warunicorn19 warunicorn19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!🎉, Thanks @NikhilSharma03

@vinayaksh42
Copy link
Member

Great changes @NikhilSharma03 , This feels a lot more responsive

@vinayaksh42
Copy link
Member

opera_XCheW4WPA0
@NikhilSharma03 can you checkout the home page of docs. I think it would be great to have the same padding and margin for this page as well.

@vinayaksh42 vinayaksh42 self-requested a review August 11, 2021 19:32
@leecalcote leecalcote merged commit 40efbfc into layer5io:master Aug 12, 2021
@leecalcote
Copy link
Member

I missed @vinayaksh42's last comment and requested change. Please do address this.

@leecalcote
Copy link
Member

I'm sorry about that, gents. I missed that last request for an update.

@NikhilSharma03
Copy link
Member Author

opera_XCheW4WPA0
@NikhilSharma03 can you checkout the home page of docs. I think it would be great to have the same padding and margin for this page as well.

Yes i have fixed it in my last PR.

@NikhilSharma03 NikhilSharma03 deleted the section1_overview branch August 12, 2021 02:32
@NikhilSharma03
Copy link
Member Author

I'm sorry about that, gents. I missed that last request for an update.

Flash : I am the fastest man alive
@leecalcote : Hold my merge 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants