Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed slack star workflow #157

Merged
merged 3 commits into from
Aug 9, 2021
Merged

fixed slack star workflow #157

merged 3 commits into from
Aug 9, 2021

Conversation

warunicorn19
Copy link
Member

@warunicorn19 warunicorn19 commented Aug 9, 2021 •
edited
Loading

Signed-off-by: Aditya Chaterjee [email protected]

Description
Tried fixing the workflow to count the stars on getnighthawk on slack
This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@warunicorn19
fixed slack star workflow
13f4717 
Signed-off-by: Aditya Chaterjee <[email protected]>
@welcome
Copy link

welcome bot commented Aug 9, 2021

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@warunicorn19
fixed an oopsie
b795c37 
Signed-off-by: Aditya Chaterjee <[email protected]>
sayantan1413
sayantan1413 approved these changes Aug 9, 2021
View reviewed changes
Copy link
Member

@sayantan1413 sayantan1413 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉. Thanks @warunicorn19 !

@DelusionalOptimist
Copy link
Contributor

@warunicorn19 looks good. While you're at it, why not fix https://github.com/warunicorn19/getnighthawk/blob/b795c37443caa4dfa53e6d9dcae383de8c703efc/.github/workflows/slack.yml#L16 as well 🙂 . It should be getnighthawk and not nighthawk-go

@warunicorn19
changed to getnighthawk
dc4e9f2 
Signed-off-by: Aditya Chaterjee <[email protected]>
@warunicorn19
Copy link
Member Author

@warunicorn19 looks good. While you're at it, why not fix https://github.com/warunicorn19/getnighthawk/blob/b795c37443caa4dfa53e6d9dcae383de8c703efc/.github/workflows/slack.yml#L16 as well 🙂 . It should be getnighthawk and not nighthawk-go

Made the change @DelusionalOptimist 😄

DelusionalOptimist
DelusionalOptimist approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@DelusionalOptimist DelusionalOptimist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. ✔️
Thanks @warunicorn19 👍

@DelusionalOptimist DelusionalOptimist merged commit e1fcd6a into layer5io:master Aug 9, 2021
@welcome
Copy link

welcome bot commented Aug 9, 2021

Thanks for your contribution to the Layer5 community! 🎉

Congrats!

@warunicorn19 warunicorn19 deleted the slack_stars branch August 9, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayantan1413 sayantan1413 sayantan1413 approved these changes

@DelusionalOptimist DelusionalOptimist DelusionalOptimist approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@warunicorn19 @DelusionalOptimist @sayantan1413