Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site] Fixed Dropdown Close Issue --signoff #134

Merged
merged 3 commits into from
Jun 12, 2021
Merged

[Site] Fixed Dropdown Close Issue --signoff #134

merged 3 commits into from
Jun 12, 2021

Conversation

NikhilSharma03
Copy link
Member

Description
This PR fixes two issues.

1. Dropdown Close Issue in several parts of the website.

  • Before Changes
Issue.DropDown.mp4
Section.Issue.DD.mp4
  • After Changes
Fixed.DropDown.mp4
Section.Fix.DD.mp4

2. Button hover issue

  • Before Changes
Button.Hover.Issue.mp4
  • After Changes
Button.Hover.Fix.mp4

Notes for Reviewers
Let me know if there are any other changes we can make. Thank you.

Signed commits

  • Yes, I signed my commits.

@netlify
Copy link

netlify bot commented Jun 12, 2021

✔️ Website preview ready!

🔨 Explore the source changes: c466b89

🔍 Inspect the deploy log: https://app.netlify.com/sites/getnighthawk/deploys/60c489f0dbff5f0007bdbadf

😎 Browse the preview: https://deploy-preview-134--getnighthawk.netlify.app

@leecalcote leecalcote requested review from a team June 12, 2021 11:27
Copy link
Member

@vinayaksh42 vinayaksh42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work @NikhilSharma03, All the changes are looking perfect in the website preview

@Jashpatel1 Jashpatel1 merged commit 2bcf24c into layer5io:master Jun 12, 2021
@NikhilSharma03 NikhilSharma03 deleted the fixed_dropdown_close branch June 12, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants