Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Site] Updated docs section style #128

Merged
merged 3 commits into from
Jun 5, 2021
Merged

[Site] Updated docs section style #128

merged 3 commits into from
Jun 5, 2021

Conversation

NikhilSharma03
Copy link
Member

Signed-off-by: Nikhil [email protected]

Description
Updated style and color of docs section.

After Changes

Screenshot from 2021-06-03 17-55-52

This PR fixes #124

Notes for Reviewers
Let me know if there are any other changes or fixes we can make.

Signed commits

  • Yes, I signed my commits.

@netlify
Copy link

netlify bot commented Jun 3, 2021 •
edited
Loading

✔️ Website preview ready!

🔨 Explore the source changes: 94c031b

🔍 Inspect the deploy log: https://app.netlify.com/sites/getnighthawk/deploys/60ba4aaf9ae5870008f6796c

😎 Browse the preview: https://deploy-preview-128--getnighthawk.netlify.app

@NikhilSharma03
Copy link
Member Author

@vinayaksh42 @JubayerJoy Can you please review the changes? Thank you.

JubayerJoy
JubayerJoy reviewed Jun 3, 2021
View reviewed changes
Copy link
Member

@JubayerJoy JubayerJoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NikhilSharma03 really nice work! 🚀
Some suggestions,

  1. The menu is not closing on click, please change it so it collapses on click.
  2. Keeping the first menu item open by default would look nicer and give good UX.

@leecalcote leecalcote requested a review from Anita-ihuman June 4, 2021 02:08
@Anita-ihuman
Copy link
Contributor

  1. The menu is not closing on click, please change it so it collapses on click.

well, I think keeping the dropdown closed is better tho. This is because by the time the details, expected to be on the doc page are complete, the page would look too busy having the dropdown open by default.

Anita-ihuman
Anita-ihuman reviewed Jun 4, 2021
View reviewed changes
Copy link
Contributor

@Anita-ihuman Anita-ihuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking this up.
it would be great if the dropdown closes back on clicking the button.
right now it just Opens.

@leecalcote
Copy link
Member

@NikhilSharma03, are you trying to tell the user that "there's no going back"? ;)

@NikhilSharma03
Copy link
Member Author

NikhilSharma03 commented Jun 4, 2021 •
edited
Loading

@Anita-ihuman @JubayerJoy
Changes to make :

  • Dropdown closes back on clicking the button
  • Keeping the dropdown closed

Can you please confirm the changes? Thank you.

@Anita-ihuman
Copy link
Contributor

@Anita-ihuman @JubayerJoy
Changes to make :

  • Dropdown closes back on clicking the button
  • Keeping the dropdown closed

Can you please confirm the changes? Thank you.

Yes, Those are the changes to be made.

@NikhilSharma03
fixed dropdown close
2438fb2 
Signed-off-by: Nikhil <[email protected]>
@NikhilSharma03
Copy link
Member Author

NikhilSharma03 commented Jun 4, 2021 •
edited
Loading

@Anita-ihuman @JubayerJoy @leecalcote Can you please review the changes?

vinayaksh42
vinayaksh42 suggested changes Jun 4, 2021
View reviewed changes
docs/_sass/getnighthawk.scss Outdated Show resolved Hide resolved
@NikhilSharma03
Removed empty class
94c031b 
Signed-off-by: Nikhil <[email protected]>
vinayaksh42
vinayaksh42 approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@vinayaksh42 vinayaksh42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @NikhilSharma03

Anita-ihuman
Anita-ihuman approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@Anita-ihuman Anita-ihuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

JubayerJoy
JubayerJoy approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@JubayerJoy JubayerJoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really Nice work @NikhilSharma03 🚀
LGTM 🎈

@vinayaksh42 vinayaksh42 merged commit d44f0bf into layer5io:master Jun 5, 2021
@NikhilSharma03 NikhilSharma03 deleted the docs_section_style branch June 5, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anita-ihuman Anita-ihuman Anita-ihuman approved these changes

@vinayaksh42 vinayaksh42 vinayaksh42 approved these changes

@JubayerJoy JubayerJoy JubayerJoy approved these changes

Assignees
No one assigned
Labels
area/ux
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Site] Change color and style of menu items
5 participants
@NikhilSharma03 @Anita-ihuman @leecalcote @JubayerJoy @vinayaksh42