Changes to the Makefile and kjv.tsv #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple typo that didn't seem to do anything
Linux Libertine O is better than FreeSerif.
I added the rest of the Psalms that Bontibon didn't think to and some other things.
Added some light life to the help menu and interactive prompt
Randomly and utterly hilarious, I have found this typo there.
Changed the TSV to be in "Book, abr., book #, ch. #, v#" order. Also added headers for the five books of the Psalms---a division that was added at some point by Jews to mimic the Torah and is often in Bibles.
The words in italics are words added by the translators to help flow or structure. They are not malicious in design, but they wanted it clear that those words were technically added and not part of the translation process. They have been wrapped in <em></em> tags, rather than square brackets. All words in brackets are words and passages that are in some manuscripts in the original languages but not others.
Replaced the round brackets with ANSI escape characters. This would require having less set to default to `-r` or `-R`. i.e. PAGE="less -R"
+ Added the markers for the five books of Psalms + All italicised text is no longer in square brackets, but round. + All manuscript variations are now demarked by square brackets and not round. This is done to avoid having to use ANSI escape sequences.
…into kjv-bontibon-pce
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differences of Note:
installanduninstallfunction to the Makefile.\ESC[[3mSome text\ESC[[0m). This is most likely a feature that would be better handled by a function added to the base KJV program, which was beyond my capacity to write.The Pure Cambridge Edition (PCE) is a KJV critical edition based off the various Oxford prints which continued to update various issues that crept in through the printing process. Sadly, this version does not have the Cambridge paragraph divisions. In the case of the Old Testament, they usually follow the divisions found in the Hebrew Leningrad Codex (based off of observation, not fact.) I would like to eventually add those in, but that would be take me hundreds of hours or a small team dozens.
I wish I could only request a handful of commits—my commit history is a fair bit messy, especially from having to clean up this branch for me to merge. Thankfully, though, should you choose to merge any commits, there are only a few which are pursuant, and of course, those can be manually chosen (though it isn't that straight forward), and all of them are recent.