-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@react-native-picker/picker as a peerDependency to solve duplicate/Invariant violation issue #464
Conversation
When can we expect this PR to be merged in? 🙂 Nice work @Rehubbard! This should solve both these 2 open issues: |
…i jest test failing
@lfkwtz any updates on merging this PR? Is there anything else I can do to help it move along in the process? Just ran into this issue again when upgrading our entire project and all dependencies. Thanks in advance! |
|
Seems like the auto-merge failed because of Could the |
@Rehubbard please see above |
Any updates? I realize the owners @LawnStarterTeam may not have time to properly maintain this library. However, maybe give others the access needed so that it can be maintained. Let the community help! It beats having hundreds of forks where others are likely making the some of the same changes and possibly adding new features that will never be incorporated because the PRs aren't getting merged. |
seems like lockfile changes are missing from this, no? |
@Rehubbard can you also bump to ^2.4.0? |
Problem
On a fresh install and following the readme steps, you end up with 2 versions of
@react-native-picker/picker
installed. The one that you install yourself (the readme says to) and the version that's listed in the package.json dependencies.This causes the library to crash with this error:

sidenote: For me, I had already installed
@react-native-picker/picker
v2 and was using it before this package. And it was breaking due to this package installing v1 as well. I believe this is a good usecase for peerDependencies.Solution
Move
@react-native-picker/picker
to peerDependencies in package.json. Keep separate install step in readme.