-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest master Rocket version #89
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rocket::handler -> rocket::route - request.get_param() -> request.param - Change attach -> ignite and ignite -> build - Update lifetime signature of FromRequest
In rocket 0.5 "/<catch_all_options_route..>" should match path "/" too hence the collision.
This reverts commit 69db6d5
Could you update |
Done |
lawliet89
approved these changes
Apr 26, 2021
Thanks for your contribution! |
j03-dev
added a commit
to j03-dev/rocket_cors
that referenced
this pull request
Nov 2, 2023
lawliet89
added a commit
that referenced
this pull request
Nov 17, 2023
* Update to latest master Rocket version (#89) * Fix "useless `vec!`" * Fix docs --------- Co-authored-by: Yong Wen Chua <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of some change in rocket's master branch, currently this library cannot be use with rocket's master branch. This PR update the library to be compatible with latest rocket's master branch.
Changes
rocket::ignite()
(which was previously the first phase) are now replaced byrocket::build()
rocket::Rocket
now have one type parameter signifying the phaseon_attach()
withon_ignite()
rocket::handler
withrocket::route
rocket::route::Handler
don't have the same lifetime signature as (now removed)rocket::handler::Handler
rocket::log_
are removedrocket::Request::get_param()
withrocket::Request::param()
"/<p..>"
won't match"/"
but now it will). this change cause the routes returned fromcatch_all_options_routes()
to collide so I remove the empty route.