Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix fteqcc failure due to outdated glibc version in github runners #227

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

pnahratow
Copy link
Collaborator

@pnahratow pnahratow commented Nov 1, 2024

Description of Changes

fteqcc nees glibc version 2.38 at minimum. This might be a recent update who knows. However the Ubuntu-latest tag seems to also pick runners using Ubuntu 22.04 which is too old and doesn't satisfy the libc dependency. I set this manually to 24.04 but this should be reverted at some point. Actually it should work right now. This feels like a GitHub bug. They have 24.04 runners available but latest points to something older.

Checklist


  • I have read the LibreQuake contribution guidelines
  • I have thoroughly tested my changes to the best of my ability
  • I confirm I have not contributed anything that would impact LibreQuake's licensing and usage
  • This Pull Request fixes a critical issue that should be reviewed and merged as soon as possible

Copy link
Owner

@lavenderdotpet lavenderdotpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me will make an issue about reverting this once this is fixed on github's side

Copy link
Owner

@lavenderdotpet lavenderdotpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! just noticed an issue
this should be labled as CI and not BUILD

BUILD: Modification of our build scripts and/or tools.
CI: Modification of the GitHub Actions Pipeline(s).

other then that it looks fine and needs to be merged asap

@pnahratow pnahratow changed the title BUILD: Fix libc fteqcc version conflict CI: Fix fteqcc failure due to outdated glibc version in github runners Nov 2, 2024
@lavenderdotpet lavenderdotpet merged commit 345714a into lavenderdotpet:main Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants