Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaked udeath #179

Merged
merged 2 commits into from
Nov 9, 2024
Merged

Tweaked udeath #179

merged 2 commits into from
Nov 9, 2024

Conversation

Ogrobastard
Copy link
Contributor

@Ogrobastard Ogrobastard commented Oct 6, 2024

Modified version of existing "udeath" by user "Ospaggi", as originally posted in LibreQuake discord channel "audio-music".
Second attempt of sending the file after merging the latest main.

Description of Changes


Using Audacity, I've reversed the original sample and made a small trim to remove repetitive noises.

Visual Sample


373906119-9dfda5d3-b1b6-4dd8-b4c9-42ee2fbfb0f3

Checklist


  • I have read the LibreQuake contribution guidelines
  • I have thoroughly tested my changes to the best of my ability
  • I confirm I have not contributed anything that would impact LibreQuake's licensing and usage
  • This Pull Request fixes a critical issue that should be reviewed and merged as soon as possible

@MotoLegacy
Copy link
Collaborator

I've unchecked "critical" as this is not a critical issue. Also, be mindful next week that contribution guidelines will be enforced.

@Ogrobastard
Copy link
Contributor Author

Ogrobastard commented Oct 6, 2024

I've unchecked "critical" as this is not a critical issue. Also, be mindful next week that contribution guidelines will be enforced.

Sorry 'bout that, thought it was one of the problems that gave me trouble with the first pull request. Will "not check" next time! ;)

@lavenderdotpet
Copy link
Owner

what does the meta data look like

@Ogrobastard
Copy link
Contributor Author

what does the meta data look like

udeath.json
Didn't make modifications to it, just the audio file itself.

@lavenderdotpet
Copy link
Owner

what does the meta data look like

udeath.json
Didn't make modifications to it, just the audio file itself.

well there should be a modification to it
make sure to add Ur credits to the author list

Copy link
Collaborator

@MotoLegacy MotoLegacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as needs work since Lav requested changes but did not submit this request.

Copy link
Owner

@lavenderdotpet lavenderdotpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gonna go ahead and approve this
with the audio index being a thing
meta data is less of an issue

@lavenderdotpet lavenderdotpet dismissed MotoLegacy’s stale review November 9, 2024 06:29

this request for change was done for me and I've changed my review on it

@lavenderdotpet lavenderdotpet merged commit 56e9b83 into lavenderdotpet:main Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants