Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUILD, MAP: Removed missing textures from a bunch of map files. #177

Merged
merged 8 commits into from
Oct 6, 2024
Merged

BUILD, MAP: Removed missing textures from a bunch of map files. #177

merged 8 commits into from
Oct 6, 2024

Conversation

Zungrysoft
Copy link
Collaborator

@Zungrysoft Zungrysoft commented Oct 5, 2024 •
edited
Loading

Description of Changes

Removed all uses of hp25_side texture from the megahealth brush model to get rid of compiler warnings.

Visual Sample

N/A

Checklist

  • I have read the LibreQuake contribution guidelines
  • I have thoroughly tested my changes to the best of my ability
  • I confirm I have not contributed anything that would impact LibreQuake's licensing and usage
  • This Pull Request fixes a critical issue that should be reviewed and merged as soon as possible

@Zungrysoft
Copy link
Collaborator Author

Weird. It's failing with WARNING: unable to find texture skip on b_bh10_lite.map, but that map doesn't have any skip textures in it. It's not failing on any of the other bmodels as far as I can tell.

@Zungrysoft
Copy link
Collaborator Author

Okay, it's only failing on bmodels which don't use lq_dev.wad. So I've added that WAD to the failing bmodels.

@Zungrysoft Zungrysoft mentioned this pull request Oct 5, 2024
Closed
4 tasks
@Zungrysoft Zungrysoft force-pushed the zungryware/megahealth-texture-fix branch from 93b1cdb to eff35b0 Compare October 5, 2024 01:41
@Zungrysoft Zungrysoft changed the title BUILD, MAP: Removed unused texture from megahealth BUILD, MAP: Removed missing textures from a bunch of map files. Oct 5, 2024
@Zungrysoft Zungrysoft force-pushed the zungryware/megahealth-texture-fix branch from 82e4081 to 7c20802 Compare October 5, 2024 02:20
@Zungrysoft Zungrysoft marked this pull request as ready for review October 5, 2024 17:00
pnahratow
pnahratow approved these changes Oct 5, 2024
View reviewed changes
Copy link
Collaborator

@pnahratow pnahratow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes

@lavenderdotpet
Copy link
Owner

lavenderdotpet commented Oct 6, 2024 •
edited
Loading

@Zungrysoft merge when Ur ready

MotoLegacy
MotoLegacy approved these changes Oct 6, 2024
View reviewed changes
Copy link
Collaborator

@MotoLegacy MotoLegacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patchwork!

@Zungrysoft Zungrysoft merged commit 5cf8022 into main Oct 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnahratow pnahratow pnahratow approved these changes

@MotoLegacy MotoLegacy MotoLegacy approved these changes

@lavenderdotpet lavenderdotpet lavenderdotpet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zungrysoft @lavenderdotpet @pnahratow @MotoLegacy