GFX: Fix colormap having incorrect fullbright count #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https: //discord.com/channels/464531227509260291/491346068886519828/1274258963222892545 Co-Authored-By: Andrei Drexler <[email protected]>
|
Awesome, a good catch. Can you change your commit message to provide detail about what the fix REALLY is though? Something like, GFX: Fix colormap having incorrect fullbright count It's important when writing commit messages to provide something tangible but not overly verbose. Additionally, we should probably generate the colormap as part of a build script. Can you open an issue requesting this? Not a PR blocker, but nice to have. |
lavenderdotpet
changed the title
thank u good catch and thanks for the advice |
MotoLegacy
requested changes
Aug 27, 2024
hi im unsure how to update the commit msg |
|
That's fine then, no worries since we are not yet enforcing our condition guide |
MotoLegacy
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https: //discord.com/channels/464531227509260291/491346068886519828/1274258963222892545
broken
fixed