Synaptic delays for Dense connections #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he outputs, when it needs to be initialized to the size of the inputs
…lays to the connections.
…he DenseDelay process model.
6 tasks
PhilippPlank
requested review from
mathisrichter,
gkarray,
weidel-p and
bamsumit
bamsumit
requested changes
Feb 16, 2023
There was a problem hiding this comment.
Thanks @PhilippPlank for taking care of this. It looks nice and clean. I have added some comments for your consideration.
gkarray
approved these changes
Feb 17, 2023
bamsumit
approved these changes
Feb 17, 2023
16 tasks
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
* Added Delay connection process and process model (floating point). * fixed bug in Delay() process. s_buff was initialized to the size of the outputs, when it needs to be initialized to the size of the inputs * updated docstring for delay process * added license information * reformatting to improve line lengths * updating formatting based on linting results * added unit tests for delay process * finished adding unittests and fixed linting errors * added __init__.py file to the test directory for the delay process * test_models.py import from tests.lava * Added DenseDelay Process class, which inherits from Dense and adds delays to the connections. * added PyDenseDelayModelFloat, the floating-point implementation for the DenseDelay process model. * small fixes * Added DelayDense process and process model * fix linting * deleted unused files * deleted unused files * modification from review suggestions * modifications from reviewer suggestions --------- Co-authored-by: kds300 <[email protected]> Co-authored-by: kds300 <[email protected]> Co-authored-by: Marcus G K Williams <[email protected]> Co-authored-by: bamsumit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: #237
Based on PR: #267
Objective of pull request: As a user, I want to be able to specify synaptic delays in the Dense Process to enable algorithmic work.
Pull request checklist
Your PR fulfills the following requirements:
flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locallypytest) passes locallyPull request type
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Supplemental information