Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialization of Dense with all-zero weights #585

Merged
merged 2 commits into from
Jan 27, 2023
Merged

Initialization of Dense with all-zero weights #585

merged 2 commits into from
Jan 27, 2023

Conversation

PhilippPlank
Copy link
Contributor

@PhilippPlank PhilippPlank commented Jan 26, 2023 •
edited
Loading

Issue Number: #501

Objective of pull request: The automatic determination of the weight exponent given the weights does fail, if all weights are 0. As this is used in the general Dense process for Loihi2HwCfg (running on Loihi 2), initializing weights with just 0 is currently not possible.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@PhilippPlank PhilippPlank linked an issue Jan 26, 2023 that may be closed by this pull request
Initialization of Dense with all-zero weights #501
Closed
2 tasks
gkarray
gkarray approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@gkarray gkarray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

weidel-p
weidel-p approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@weidel-p weidel-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@PhilippPlank PhilippPlank merged commit 043a3c2 into main Jan 27, 2023
@PhilippPlank PhilippPlank deleted the fix_weight_utils branch January 27, 2023 14:06
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
@PhilippPlank
Initialization of Dense with all-zero weights (lava-nc#585)
348f63f 
* fixed using all 0 weight matrix

* added unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkarray gkarray gkarray approved these changes

@weidel-p weidel-p weidel-p approved these changes

@mathisrichter mathisrichter Awaiting requested review from mathisrichter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initialization of Dense with all-zero weights
3 participants
@PhilippPlank @weidel-p @gkarray