Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enablement of RefPort to Var/VarPort connections #46

Merged
merged 11 commits into from
Nov 17, 2021
Merged

Enablement of RefPort to Var/VarPort connections #46

merged 11 commits into from
Nov 17, 2021

Conversation

PhilippPlank
Copy link
Contributor

This change allows access to variables (Vars) of another Process through the usage of RefPorts and VarPorts.
Initial enablement.

Limitations:

  • Currently supports only 1:1 (RefPort to Var/VarPort) connections

@PhilippPlank PhilippPlank added 1-feature New feature request area: magma/runtime Issues with something in lava/magma/runtime area: magma/core Issues with something in lava/magma/core area: magma/compiler Issues with something in lava/magma/compiler labels Nov 12, 2021
@PhilippPlank PhilippPlank self-assigned this Nov 12, 2021
@PhilippPlank PhilippPlank linked an issue Nov 12, 2021 that may be closed by this pull request
Enable RefPort connections #43
Closed
awintel
awintel previously approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@awintel awintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@awintel awintel dismissed their stale review November 12, 2021 16:35

Too early

awintel
awintel requested changes Nov 14, 2021
View reviewed changes
Copy link
Contributor

@awintel awintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Most feedback is about proper documentation and a couple minor code cleanup here and there.

src/lava/magma/core/model/py/ports.py Outdated Show resolved Hide resolved
src/lava/magma/core/model/py/ports.py Outdated Show resolved Hide resolved
src/lava/magma/core/model/py/ports.py Show resolved Hide resolved
src/lava/magma/core/model/py/ports.py Show resolved Hide resolved
src/lava/magma/core/model/py/ports.py Outdated Show resolved Hide resolved
src/lava/magma/compiler/builder.py Outdated Show resolved Hide resolved
src/lava/magma/compiler/builder.py Outdated Show resolved Hide resolved
src/lava/magma/compiler/builder.py Show resolved Hide resolved
src/lava/magma/compiler/builder.py Show resolved Hide resolved
tests/lava/magma/core/process/test_ports.py Outdated Show resolved Hide resolved
mathisrichter
mathisrichter requested changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@mathisrichter mathisrichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only had a look at the interface and browsed through the rest. All looks good. I found a few minor things, mostly typos in comments, that need to be addressed.

tests/lava/magma/core/model/test_py_model.py Outdated Show resolved Hide resolved
tests/lava/magma/runtime/test_ref_var_ports.py Outdated Show resolved Hide resolved
tests/lava/magma/runtime/test_ref_var_ports.py Outdated Show resolved Hide resolved
tests/lava/magma/core/process/test_ports.py Outdated Show resolved Hide resolved
src/lava/magma/core/model/interfaces.py Outdated Show resolved Hide resolved
elvinhajizada
elvinhajizada requested changes Nov 15, 2021
View reviewed changes
Copy link
Collaborator

@elvinhajizada elvinhajizada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Philipp, I had look at tests, hence usage part of RefPort implementation. I have put comments for corresponding lines

tests/lava/magma/compiler/test_compiler.py Show resolved Hide resolved
tests/lava/magma/compiler/test_compiler.py Outdated Show resolved Hide resolved
tests/lava/magma/compiler/test_compiler.py Outdated Show resolved Hide resolved
tests/lava/magma/compiler/test_compiler.py Show resolved Hide resolved
tests/lava/magma/core/model/test_py_model.py Show resolved Hide resolved
tests/lava/magma/runtime/test_ref_var_ports.py Outdated Show resolved Hide resolved
tests/lava/magma/runtime/test_ref_var_ports.py Outdated Show resolved Hide resolved
tests/lava/magma/runtime/test_ref_var_ports.py Outdated Show resolved Hide resolved
tests/lava/magma/runtime/test_ref_var_ports.py Outdated Show resolved Hide resolved
This was referenced Nov 15, 2021
Open
Open
Open
awintel
awintel reviewed Nov 16, 2021
View reviewed changes
Copy link
Contributor

@awintel awintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good

@PhilippPlank PhilippPlank mentioned this pull request Nov 16, 2021
Closed
awintel
awintel approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@awintel awintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@elvinhajizada
Copy link
Collaborator

Looks good

@PhilippPlank PhilippPlank merged commit 7afe335 into lava-nc:main Nov 17, 2021
srrisbud pushed a commit to srrisbud/lava that referenced this pull request Nov 18, 2021
@PhilippPlank @srrisbud
Enablement of RefPort to Var/VarPort connections (lava-nc#46)
c074841 
* - Initial enablement of RefPort and VarPorts

* - Initial enablement of RefPort and VarPorts

* - Initial enablement of RefPort and VarPorts

* - Initial enablement of RefPort and VarPorts

* - Enablement of RefPorts and VarPorts - addressed change requests from PR lava-nc#46

* - Enablement of RefPorts and VarPorts - addressed change requests from PR lava-nc#46

* - Enablement of RefPorts and VarPorts - addressed change requests from PR lava-nc#46

* - Enablement of RefPorts and VarPorts - addressed change requests from PR lava-nc#46
srrisbud pushed a commit to srrisbud/lava that referenced this pull request Nov 19, 2021
@PhilippPlank @srrisbud
Enablement of RefPort to Var/VarPort connections (lava-nc#46)
f9b4ba8 
* - Initial enablement of RefPort and VarPorts

* - Initial enablement of RefPort and VarPorts

* - Initial enablement of RefPort and VarPorts

* - Initial enablement of RefPort and VarPorts

* - Enablement of RefPorts and VarPorts - addressed change requests from PR lava-nc#46

* - Enablement of RefPorts and VarPorts - addressed change requests from PR lava-nc#46

* - Enablement of RefPorts and VarPorts - addressed change requests from PR lava-nc#46

* - Enablement of RefPorts and VarPorts - addressed change requests from PR lava-nc#46
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
@PhilippPlank
Enablement of RefPort to Var/VarPort connections (lava-nc#46)
56957f5 
* - Initial enablement of RefPort and VarPorts

* - Initial enablement of RefPort and VarPorts

* - Initial enablement of RefPort and VarPorts

* - Initial enablement of RefPort and VarPorts

* - Enablement of RefPorts and VarPorts - addressed change requests from PR lava-nc#46

* - Enablement of RefPorts and VarPorts - addressed change requests from PR lava-nc#46

* - Enablement of RefPorts and VarPorts - addressed change requests from PR lava-nc#46

* - Enablement of RefPorts and VarPorts - addressed change requests from PR lava-nc#46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awintel awintel awintel approved these changes

@elvinhajizada elvinhajizada elvinhajizada approved these changes

@mathisrichter mathisrichter mathisrichter approved these changes

@mgkwill mgkwill Awaiting requested review from mgkwill

@srrisbud srrisbud Awaiting requested review from srrisbud

Assignees

@PhilippPlank PhilippPlank

Labels
1-feature New feature request area: magma/compiler Issues with something in lava/magma/compiler area: magma/core Issues with something in lava/magma/core area: magma/runtime Issues with something in lava/magma/runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable RefPort connections
4 participants
@PhilippPlank @elvinhajizada @mathisrichter @awintel